-
Notifications
You must be signed in to change notification settings - Fork 519
Remove krel patch-announce #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As discussed in the Release Engineering Meeting, we now remove `krel patch-announce` in favor of the more general `krel announce` subcommand. Further refactorings will target the `pkg/patch` package, where some of its components will be re-used by other tools. Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saschagrunert -- We should support the replacement before deprecating this.
/hold
Working on handbook updates here now: https://github.com/kubernetes/sig-release/pull/1098/files |
@saschagrunert -- More explicitly, before we remove |
Alright, those are the things
Whereas
Building the release notes again just for the mail should not be necessary, because To streamline the overall process, I suggest to reuse parts of It should be safe to remove |
SGTM! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind deprecation
/kind cleanup
What this PR does / why we need it:
As discussed in the Release Engineering Meeting, we now remove
krel patch-announce
in favor of the more generalkrel announce
subcommand.Further refactorings will target the
pkg/patch
package, where some ofits components will be re-used by other tools.
Which issue(s) this PR fixes:
Fixes #1312
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?