Skip to content

Remove krel patch-announce #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020
Merged

Remove krel patch-announce #1315

merged 1 commit into from
May 28, 2020

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind deprecation
/kind cleanup

What this PR does / why we need it:

As discussed in the Release Engineering Meeting, we now remove krel patch-announce in favor of the more general krel announce subcommand.
Further refactorings will target the pkg/patch package, where some of
its components will be re-used by other tools.

Which issue(s) this PR fixes:

Fixes #1312

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

- Removed `krel patch-announce` in favor of the more general `krel announce` subcommand

As discussed in the Release Engineering Meeting, we now remove `krel
patch-announce` in favor of the more general `krel announce` subcommand.
Further refactorings will target the `pkg/patch` package, where some of
its components will be re-used by other tools.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 27, 2020
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert -- We should support the replacement before deprecating this.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@saschagrunert
Copy link
Member Author

@saschagrunert -- We should support the replacement before deprecating this.
/hold

Working on handbook updates here now: https://github.com/kubernetes/sig-release/pull/1098/files

@justaugustus
Copy link
Member

@saschagrunert -- More explicitly, before we remove patch-announce, are we positive that announce has feature parity?

@saschagrunert
Copy link
Member Author

@saschagrunert -- More explicitly, before we remove patch-announce, are we positive that announce has feature parity?

Alright, those are the things patch-announce did:

  1. Creating an announcement mail header
  2. Building the release notes via ./relnotes
  3. Formatting the notes as HTML and merging it with the header
  4. Sending the announcement

Whereas announce only does:

  1. Downloading the announcement from the Google Cloud Bucket (previously built by anago)
  2. Sending the announcement

Building the release notes again just for the mail should not be necessary, because krel changelog already does this job (anago expects a generated HTML after the notes have been built).

To streamline the overall process, I suggest to reuse parts of pkg/patch (not removed in this PR) for the golang based anago to create the announcement on the bucket.

It should be safe to remove krel patch-announce since it is not used in production, yet.

@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label May 28, 2020
@justaugustus
Copy link
Member

SGTM!
/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5c5affe into kubernetes:master May 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 28, 2020
@saschagrunert saschagrunert deleted the patch-announce branch May 29, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The state of pkg/patch
3 participants