Skip to content

gh2gcs: add yaml config option #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2020
Merged

gh2gcs: add yaml config option #1380

merged 1 commit into from
Jun 29, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 28, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR introduce to the user of gh2gcs an option to define the download/upload releases artifacts using a YAML configuration file, which can have multiple configurations like:

releaseConfigs:
  - org: kubernetes
    repo: kubernetes
    tags:
    - v1.18.0
    - v1.17.0
    - v1.16.0
    - v1.16.1
    - v1.16.2
    includePrereleases: false
    gcsBucket: test
    releaseDir: release
    gcsCopyOptions:
      concurrent: true
      recursive: false
      noclobber: false
      allowmissing: false
  - org: kubernetes
    repo: release
    tags:
    - v0.3.4
    includePrereleases: false
    gcsBucket: test2
    releaseDir: release

Which issue(s) this PR fixes:

Fixes partially #1320

Special notes for your reviewer:

Does this PR introduce a user-facing change?

gh2gcs: add yaml config option

/cc @justaugustus @saschagrunert

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 28, 2020
@cpanato cpanato force-pushed the GH-1320-config branch 2 times, most recently from fc9001a to 15c9ff5 Compare June 28, 2020 11:22
saschagrunert
saschagrunert approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 29, 2020
@justaugustus
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 604b250 into kubernetes:master Jun 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 29, 2020
@cpanato cpanato deleted the GH-1320-config branch June 29, 2020 13:02
@justaugustus justaugustus mentioned this pull request Jun 29, 2020
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @justaugustus @k8s-ci-robot @saschagrunert