Skip to content

images: Migrate go-runner image building to k/release #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 19, 2020
Merged

images: Migrate go-runner image building to k/release #1498

merged 5 commits into from
Aug 19, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Aug 18, 2020 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Continuation of migrating kubernetes/kubernetes image building to k/release (ref: #1450, #1140)

Commits:

  • images: Initial copy of go-runner from kubernetes/kubernetes
  • images/go-runner: Enable variant building
  • images/go-runner: Add 'buster' variant
  • images/go-runner: Allow configurable go versions and use go1.13.15
  • images/go-runner: Fixup go module and build files

Requires: kubernetes/test-infra#18906

Which issue(s) this PR fixes:

Special notes for your reviewer:

go-runner also needs to be updated to go1.15, but I ran into some issues with GOPROXY, so I'm going to take that on in another PR.

Does this PR introduce a user-facing change?

- images: Migrate go-runner image building to k/release
- images/go-runner: Enable variant building
- images/go-runner: Add 'buster' variant
- images/go-runner: Allow configurable go versions and use go1.13.15
- images/go-runner: Fixup go module and build files

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2020
@justaugustus justaugustus force-pushed the go-runner branch 2 times, most recently from cab7ed1 to b50713c Compare August 18, 2020 18:42
@justaugustus justaugustus force-pushed the go-runner branch 5 times, most recently from 88e280d to a7a328a Compare August 18, 2020 21:14
@justaugustus justaugustus changed the title [WIP] Go runner images: Migrate go-runner image building to k/release Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 19, 2020
@justaugustus
Copy link
Member Author

/hold for @dims' review and for my accompanying k/test-infra PR to migrate the postsubmit
/assign @dims @tpepper @saschagrunert @hasheddan @cpanato
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
cpanato
cpanato approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hasheddan
hasheddan approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@Verolop
Copy link
Contributor

Verolop commented Aug 19, 2020

/lgtm

@justaugustus
Copy link
Member Author

/retest

xmudrii
xmudrii approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus justaugustus mentioned this pull request Aug 19, 2020
Merged
dims
dims reviewed Aug 19, 2020
View reviewed changes
@dims
Copy link
Member

dims commented Aug 19, 2020

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, hasheddan, justaugustus, Verolop, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

Thanks everyone!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit f615708 into kubernetes:master Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 19, 2020
This was referenced Aug 19, 2020
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

@listx listx Awaiting requested review from listx

+2 more reviewers

@dims dims dims left review comments

@hasheddan hasheddan hasheddan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dims dims

@saschagrunert saschagrunert

@Verolop Verolop

@tpepper tpepper

@cpanato cpanato

@xmudrii xmudrii

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
9 participants
@justaugustus @Verolop @dims @k8s-ci-robot @cpanato @xmudrii @hasheddan @saschagrunert @tpepper