feat: add includeLabels option to release-notes #4089
+55
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
jackfrancis
force-pushed
the
release-notes-includeLabels
branch
from
30d814a to
5327a67
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @puerco Let me know if this isn't code complete for adding a new release-notes config flag, this is my first PR against this project! (Also if there's anything additional I should do to advocate for new feature inclusion, happy to...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
For monorepo github repositories in the Kubernetes ecosystem that share a common master/main branch, we need a way to differentiate commits in order to use
release-notesin a fully automated way.This PR introduces a user-configurable labels filter that can be used to instruct release-notes "only include commits that originate from PRs w/ one of these labels" in the generated output.
In particular, this would enable SIG Autoscaling to leverage
release-notesfor the variety of projects under a common repository (e.g., Cluster Autoscaler, Vertical Pod Autoscaling).Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?