Skip to content

Conversation

hasheddan
Copy link
Contributor

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This adds assigning CI signal team members to issues in order to have clear ownership and ensure equal participation by shadows.

Signed-off-by: hasheddan [email protected]

Which issue(s) this PR fixes:

Fixes #1082

Special notes for your reviewer:

See issue for detailed description of why this update is being made.

/cc @kubernetes/ci-signal @spiffxp @dims @aojea @jkaniuk @BenTheElder @justaugustus @onlydole @alejandrox1

This adds assigning CI signal team members to issues
in order to have clear ownership and ensure equal
participation by shadows.

Signed-off-by: hasheddan <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2020
@hasheddan
Copy link
Contributor Author

/hold for sufficient feedback from reviewers

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2020
@aojea
Copy link
Member

aojea commented May 13, 2020

I have to admit I wasn't aware of this handbook but it looks really nice to me , congrats

@justaugustus
Copy link
Member

Nice addition, @hasheddan!
/lgtm
/approve

Feel free to lift the hold when you're ready.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasheddan
Copy link
Contributor Author

Given that all reviewers were tagged on issue that has been open for a while, and that this is a relatively small change, I am going to go ahead and lift hold and proceed. Thanks all! :)

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit d94e682 into kubernetes:master May 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 14, 2020
ashnehete added a commit to ashnehete/sig-release that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign Failing and Flaky Tests to CI Signal Team Members
4 participants