Skip to content

Use krel ff in favor of branchff in handbook #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2020
Merged

Use krel ff in favor of branchff in handbook #998

merged 1 commit into from
Mar 1, 2020

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

We remove any references to branchff in favor of krel ff, since this
should be the tool of choice for future release branch fast forwards.

Which issue(s) this PR fixes:

Refers to kubernetes/release#1129

Special notes for your reviewer:

None

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Feb 24, 2020
@saschagrunert saschagrunert mentioned this pull request Feb 24, 2020
Merged
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 24, 2020
cpanato
cpanato approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2020
justaugustus
justaugustus requested changes Feb 27, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert -- Looks pretty good! My biggest comment is that we need to make sure the Branch Manager is actually compiling the tool via:

./compile-release-tools krel

/hold

release-engineering/role-handbooks/branch-manager.md Outdated

[sig-release-x.y-blocking]: https://testgrid.k8s.io/sig-release-1.17-blocking
[`branchff`]: https://git.k8s.io/release/branchff
[`krel ff`]: https://git.k8s.io/release/cmd/krel/cmd/ff.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use this as the link. It will encourage misuse.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the link to https://git.k8s.io/release, we probably want to add a dedicated README.md for krel or at least mention it in the main README.md there.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2020
@saschagrunert
Use krel ff in favor of branchff in handbook
23917c5 
We remove any references to branchff in favor of `krel ff`, since this
should be the tool of choice for future release branch fast forwards.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2020
@justaugustus
Copy link
Member

Thanks for the update!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit e9beaab into kubernetes:master Mar 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 1, 2020
@saschagrunert saschagrunert deleted the krel-ff-handbook branch March 1, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@cpanato cpanato cpanato approved these changes

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

Assignees

@justaugustus justaugustus

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @justaugustus @k8s-ci-robot @cpanato