Skip to content

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Aug 7, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2019
@ritazh
Copy link
Member Author

ritazh commented Aug 7, 2019

/assign @cblecker

Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: changing LGTM is restricted to collaborators

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

cblecker commented Aug 7, 2019

/cc @andyzhangx @brendandburns @feiskyer @karataliu @khenidak

Looks reasonable to me, but would like some input from the sig-azure job owners

@khenidak
Copy link

khenidak commented Aug 7, 2019

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b8ce7b295f7110ca1c2fe288bfe8240210a249e

@cblecker
Copy link
Member

cblecker commented Aug 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, CecileRobertMichon, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7726788 into kubernetes:master Aug 7, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 7, 2019
@k8s-ci-robot
Copy link
Contributor

@ritazh: Updated the job-config configmap in namespace default using the following files:

  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key sig-azure-config.yaml using file config/jobs/kubernetes/sig-azure/sig-azure-config.yaml

In response to this:

Fixes kubernetes/kubernetes#79597

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Member

feiskyer commented Aug 8, 2019

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pull-kubernetes-e2e-aks-engine-azure consistently failing

6 participants