Skip to content

sig-testing: run some tests on dedicated nodepool #34630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Mar 31, 2025

Follow-up:

move some prowjobs to a dedicated nodepool in order to evaluate new instances.

Follow-up:
 - kubernetes/k8s.io#7943

move some prowjobs to a dedicated nodepool in order to evaluate new
instances.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 31, 2025
@ameukam
Copy link
Member Author

ameukam commented Mar 31, 2025

cc @BenTheElder @pohly @aojea

@ameukam
Copy link
Member Author

ameukam commented Mar 31, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2025
@ameukam
Copy link
Member Author

ameukam commented Mar 31, 2025

Currently, 3 nodes are available to match the taints:

kubectl get nodes -o custom-columns=NAME:.metadata.name,TAINTS:.spec.taints --no-headers | rg 'dedicated'
gke-prow-build-pool6-2025032723203750-2f04babf-rdch   [map[effect:NoSchedule key:dedicated value:sig-testing]]
gke-prow-build-pool6-2025032723203750-da764ec7-5hhl   [map[effect:NoSchedule key:dedicated value:sig-testing]]
gke-prow-build-pool6-2025032723203750-e834670e-lnhl   [map[effect:NoSchedule key:dedicated value:sig-testing]]

@@ -531,6 +531,11 @@ periodics:
# this is mostly for building kubernetes
memory: 9Gi
cpu: 7
tolerations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't move kind jobs, not running them in the same env makes debugging tricky and we want to make sure k/k presubmits don't break in particular

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested test-infra and other repos in the k8s.io PR for the node pool.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward to moving these, but not during code freeze, and not as the first jobs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we have to be careful because moving to this pool implies cgroups v2, and we need to make sure not only does that not break but the kind repo will need to double check the GHA to make sure we retain cgroups v1 coverage

previously cgroups v1 = prow, cgroups v2 = GHA

cc @stmcginnis @aojea

@ameukam
Copy link
Member Author

ameukam commented May 7, 2025

/close

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants