-
Notifications
You must be signed in to change notification settings - Fork 2.7k
sig-testing: run some tests on dedicated nodepool #34630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Follow-up: - kubernetes/k8s.io#7943 move some prowjobs to a dedicated nodepool in order to evaluate new instances. Signed-off-by: Arnaud Meukam <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Currently, 3 nodes are available to match the taints: kubectl get nodes -o custom-columns=NAME:.metadata.name,TAINTS:.spec.taints --no-headers | rg 'dedicated'
gke-prow-build-pool6-2025032723203750-2f04babf-rdch [map[effect:NoSchedule key:dedicated value:sig-testing]]
gke-prow-build-pool6-2025032723203750-da764ec7-5hhl [map[effect:NoSchedule key:dedicated value:sig-testing]]
gke-prow-build-pool6-2025032723203750-e834670e-lnhl [map[effect:NoSchedule key:dedicated value:sig-testing]] |
@@ -531,6 +531,11 @@ periodics: | |||
# this is mostly for building kubernetes | |||
memory: 9Gi | |||
cpu: 7 | |||
tolerations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't move kind jobs, not running them in the same env makes debugging tricky and we want to make sure k/k presubmits don't break in particular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested test-infra and other repos in the k8s.io PR for the node pool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking forward to moving these, but not during code freeze, and not as the first jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we have to be careful because moving to this pool implies cgroups v2, and we need to make sure not only does that not break but the kind repo will need to double check the GHA to make sure we retain cgroups v1 coverage
previously cgroups v1 = prow, cgroups v2 = GHA
/close |
@ameukam: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Follow-up:
move some prowjobs to a dedicated nodepool in order to evaluate new instances.