Skip to content

Add apidiff script to check go signature changes #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add apidiff script to check go signature changes #158

merged 1 commit into from
Apr 14, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 13, 2020 •
edited
Loading

Adds an API diff check to PRs to ensure they are not changing exported interfaces, types, or method signatures in incompatible ways.

Example failure when changing a method signature:

FAIL: k8s.io/utils/net contains incompatible changes:
- IsIPv6String: changed from func(string) bool to func(string) (bool, error)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and mcrute April 13, 2020 21:27
@liggitt liggitt force-pushed the apidiff branch 3 times, most recently from 595d04b to bca34dc Compare April 14, 2020 01:34
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2020
@liggitt liggitt force-pushed the apidiff branch 11 times, most recently from ddb16f6 to 7e486bc Compare April 14, 2020 02:23
@liggitt liggitt changed the title WIP - Add apidiff script to check go signature changes Add apidiff script to check go signature changes Apr 14, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2020
@dims
Copy link
Member

dims commented Apr 14, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2df71eb into kubernetes:master Apr 14, 2020
@dims dims mentioned this pull request May 18, 2020
Merged
@liggitt liggitt deleted the apidiff branch July 20, 2020 16:27
@timebertt timebertt mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@mcrute mcrute Awaiting requested review from mcrute

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @dims @k8s-ci-robot