Skip to content

Replace outdated instructions and add a tip in kubeadm-certs.md #41939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2023
Merged

Replace outdated instructions and add a tip in kubeadm-certs.md #41939

merged 2 commits into from
Jul 21, 2023

Conversation

JayBeale
Copy link
Contributor

@JayBeale JayBeale commented Jul 8, 2023

  • Removed outdated instructions, including a command-line flag that is no longer present.
  • Clarified the behavior of kubeadm certs renew, as it requires an additional parameter that wasn't cited.
  • Added a tip about copying a renewed /etc/kubernetes/admin.conf file to track the pattern from "Creating a Cluster with kubeadm"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from natalisucks July 8, 2023 03:38
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 8, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2023
@netlify
Copy link

netlify bot commented Jul 8, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e70acf5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64babee6e3edf00008e0b7ca
😎 Deploy Preview https://deploy-preview-41939--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

neolit123
neolit123 reviewed Jul 8, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the change is a net-positive. yes, --csr-only was removed.
added some suggestions.

thanks

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 8, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 20, 2023
@JayBeale JayBeale requested a review from neolit123 July 20, 2023 05:48
neolit123
neolit123 reviewed Jul 20, 2023
View reviewed changes
@neolit123
Copy link
Member

please squash the commits to one. also see
#41939 (comment)

the commits must not include @ mentions

@neolit123
Copy link
Member

LGTM
/assign rishit-dagli
up to the docs team to merge the change.

@JayBeale
Copy link
Contributor Author

please squash the commits to one. also see #41939 (comment)

the commits must not include @ mentions

OK - got it - I have changed the commit message to remove the @. I'll squash now.

@k8s-ci-robot k8s-ci-robot added language/de Issues or PRs related to German language language/zh Issues or PRs related to Chinese language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2023
Rishit-dagli
Rishit-dagli approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@Rishit-dagli Rishit-dagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c88f687202f6987388505f0741ac336f986a2a64

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rishit-dagli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit ad6205d into kubernetes:main Jul 21, 2023
@JayBeale
Copy link
Contributor Author

JayBeale commented Jul 21, 2023 •
edited
Loading

/lgtm

Thank you, @Rishit-dagli - I was able to squash all of my commits except one. I'm having trouble figuring this part of the squash out.

  • Replace outdated instructions and add a tip in kubeadm-certs.md <-- the actual one file change
  • Merge branch 'kubernetes:main' into patch-3 <-- bringing upstream changes into my forked branch

Is there any advice you can give me? I've been trying everything I can find in docs, articles, and https://kubernetes.io/docs/contribute/new-content/open-a-pr/.

ShantanuP108 pushed a commit to ShantanuP108/website that referenced this pull request Oct 2, 2025
docs(hi): Enhance Hindi README with missing sections
c0d3fbc 
Added missing sections from English README:
- Prerequisites (npm, Go, Hugo, Docker)
- Hugo segments feature for faster builds
- Building API reference pages section
- Troubleshooting section (Hugo extended, macOS file limits)
- New contributor ambassadors section
- Windows-specific Git submodule instructions
- Improved formatting to match English structure

This brings the Hindi README to parity with the English version
and improves accessibility for Hindi-speaking developers.

Fixes kubernetes#41939

Signed-off-by: Shantanu Pandey <[email protected]>
@ShantanuP108 ShantanuP108 mentioned this pull request Oct 2, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalisucks natalisucks Awaiting requested review from natalisucks

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

2 more reviewers

@neolit123 neolit123 neolit123 left review comments

@Rishit-dagli Rishit-dagli Rishit-dagli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Rishit-dagli Rishit-dagli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JayBeale @neolit123 @k8s-ci-robot @Rishit-dagli