-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[fa] Localize contribute/review #51934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fa] Localize contribute/review #51934
Conversation
1. اعتبارسنجی Issue | ||
|
||
- مطمئن شوید که Issue مربوط به مستندات وبسایت است. برخی Issueها با پاسخ سریع یا ارجاع بسته میشوند. | ||
(به بخش [درخواستهای پشتیبانی یا گزارش باگ کد](#support-requests-or-code-bug-reports) مراجعه کنید.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(به بخش [درخواستهای پشتیبانی یا گزارش باگ کد](#support-requests-or-code-bug-reports) مراجعه کنید.) | |
(به بخش [درخواستهای پشتیبانی یا گزارش باگ کد](#درخواستهای-پشتیبانی-یا-گزارش-باگ-کد) مراجعه کنید.) |
Heading links must be same as translated version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right about that. I also noticed that Zero-width non-joiners (which we typically use, for example, in pluralization) can break these links. To avoid that, I replaced them with regular spaces, even though it's not considered best practice in Persian.
c035dfe
to
c078e7b
Compare
08cd6a8
to
a983346
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
172c552
to
de1f05c
Compare
de1f05c
to
24ef82b
Compare
@mamrezb Thank you for implementing the suggested changes. Let’s continue our conversation about improving the Persian documentation on Slack. One suggestion: commit the reviewers’ suggestions to your PR and then squash them into your first commit. This way, their contributions remain visible. /lgtm |
@xirehat: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sounds good, let’s adopt that approach for our future PRs. |
Hi @seokho-son, this PR is now ready to merge. Could you please review it and add /lgtm if everything looks good? |
/language fa |
/lgtm Thanks @mamrezb and the Persian localization team members for the review. Hi @divya-mohan0209 |
LGTM label has been added. Git tree hash: 76ec14ec65a0971ac02e5525cb327c755c2dd43b
|
Thanks @seokho-son for the LGTM. Really appreciate your support on the Persian localization effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your Translations
@natalisucks All checks are green. When convenient, could you review and merge this PR? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natalisucks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[fa] Add Persian localization for contribute/review docs