Skip to content

Conversation

mamrezb
Copy link
Contributor

@mamrezb mamrezb commented Aug 16, 2025

[fa] Add Persian localization for contribute/review docs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2025
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 16, 2025
1. اعتبارسنجی Issue

- مطمئن شوید که Issue مربوط به مستندات وب‌سایت است. برخی Issueها با پاسخ سریع یا ارجاع بسته می‌شوند.
(به بخش [درخواست‌های پشتیبانی یا گزارش باگ کد](#support-requests-or-code-bug-reports) مراجعه کنید.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(به بخش [درخواست‌های پشتیبانی یا گزارش باگ کد](#support-requests-or-code-bug-reports) مراجعه کنید.)
(به بخش [درخواست‌های پشتیبانی یا گزارش باگ کد](#درخواست‌های-پشتیبانی-یا-گزارش-باگ-کد) مراجعه کنید.)

Heading links must be same as translated version

Copy link
Contributor Author

@mamrezb mamrezb Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right about that. I also noticed that Zero-width non-joiners (which we typically use, for example, in pluralization) can break these links. To avoid that, I replaced them with regular spaces, even though it's not considered best practice in Persian.

@mamrezb mamrezb force-pushed the fa-contribute-review branch from c035dfe to c078e7b Compare August 17, 2025 18:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 17, 2025
@mamrezb mamrezb force-pushed the fa-contribute-review branch 2 times, most recently from 08cd6a8 to a983346 Compare August 18, 2025 13:56
Copy link

netlify bot commented Aug 18, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 24ef82b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68a4ca35b16ced0008f732a9
😎 Deploy Preview https://deploy-preview-51934--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mamrezb mamrezb force-pushed the fa-contribute-review branch 3 times, most recently from 172c552 to de1f05c Compare August 19, 2025 18:36
@mamrezb mamrezb force-pushed the fa-contribute-review branch from de1f05c to 24ef82b Compare August 19, 2025 19:02
@xirehat
Copy link
Member

xirehat commented Aug 19, 2025

@mamrezb Thank you for implementing the suggested changes. Let’s continue our conversation about improving the Persian documentation on Slack.

One suggestion: commit the reviewers’ suggestions to your PR and then squash them into your first commit. This way, their contributions remain visible.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@xirehat: changing LGTM is restricted to collaborators

In response to this:

@mamrezb Thank you for implementing the suggested changes. Let’s continue our conversation about improving the Persian documentation on Slack.

One suggestion: commit the reviewers’ suggestions to your PR and then squash them into your first commit. This way, their contributions remain visible.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mamrezb
Copy link
Contributor Author

mamrezb commented Aug 19, 2025

@mamrezb Thank you for implementing the suggested changes. Let’s continue our conversation about improving the Persian documentation on Slack.

One suggestion: commit the reviewers’ suggestions to your PR and then squash them into your first commit. This way, their contributions remain visible.

/lgtm

Sounds good, let’s adopt that approach for our future PRs.

@mamrezb
Copy link
Contributor Author

mamrezb commented Aug 19, 2025

Hi @seokho-son, this PR is now ready to merge. Could you please review it and add /lgtm if everything looks good?

@xirehat
Copy link
Member

xirehat commented Aug 22, 2025

/language fa

@k8s-ci-robot k8s-ci-robot added the language/fa Issues or PRs related to Persian language label Aug 22, 2025
@seokho-son
Copy link
Member

/lgtm

Thanks @mamrezb and the Persian localization team members for the review.

Hi @divya-mohan0209
This PR LGTM, could you check this PR and add your approval ? :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 76ec14ec65a0971ac02e5525cb327c755c2dd43b

@mamrezb
Copy link
Contributor Author

mamrezb commented Aug 22, 2025

/lgtm

Thanks @mamrezb and the Persian localization team members for the review.

Hi @divya-mohan0209 This PR LGTM, could you check this PR and add your approval ? :)

Thanks @seokho-son for the LGTM. Really appreciate your support on the Persian localization effort.

Copy link

@Behiuu Behiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your Translations

@xirehat
Copy link
Member

xirehat commented Sep 13, 2025

@natalisucks All checks are green. When convenient, could you review and merge this PR?

@natalisucks
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit a451e00 into kubernetes:dev-1.33-fa.1 Sep 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fa Issues or PRs related to Persian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants