Skip to content

[ko] Sync /ko/docs/concepts/overview/components.md to match latest en contents #51936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2025
Merged

[ko] Sync /ko/docs/concepts/overview/components.md to match latest en contents #51936

merged 1 commit into from
Sep 20, 2025

Conversation

wonyongg
Copy link
Member

Description

Sync Korean doc /ko/docs/concepts/overview/components.md with the latest English version.
Updated the contents to reflect recent changes in the upstream English document, ensuring consistency between the two versions.

Issue

Closes: #51935

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2025
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 16, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e6a8baa
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68ce88378ed4b50008e2353f
😎 Deploy Preview https://deploy-preview-51936--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jongwooo
Copy link
Member

/assign

@wonyongg wonyongg changed the title Sync/ko/docs/concepts/overview/components.md to match latest en contents [ko] Sync/ko/docs/concepts/overview/components.md to match latest en contents Aug 20, 2025
jongwooo
jongwooo reviewed Aug 21, 2025
View reviewed changes
Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wonyongg 고생하셨습니다. 사소한 리뷰 사항 남겨두었습니다:)

Eundms
Eundms suggested changes Aug 25, 2025
View reviewed changes
ianychoi
ianychoi suggested changes Sep 4, 2025
View reviewed changes
Copy link
Member

@ianychoi ianychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good but would you please refer to the URL which I referenced? I believe the perspective which blog is mentioned might reflect translation style, which is generally different from Kubernetes Korean Docs L10n team styles.

@wonyongg wonyongg mentioned this pull request Sep 8, 2025
Closed
@ianychoi
Copy link
Member

ianychoi commented Sep 9, 2025

Actually, my intention is to ask @wonyongg to review & improve overall content, not just a few lines I mentioned.

Also, I clearly see that @jongwooo 's comment has not been still addressed.

image

@wonyongg
Copy link
Member Author

wonyongg commented Sep 9, 2025 •
edited
Loading

Actually, my intention is to ask @wonyongg to review & improve overall content, not just a few lines I mentioned.

Also, I clearly see that @jongwooo 's comment has not been still addressed.

@ianychoi
Sorry, I hadn’t thought of that, thank you. I’ve now addressed all of jongwooo’s comments and removed all of the Japanese-style translation phrasing.

@jongwooo
Copy link
Member

/retitle [ko] Sync /ko/docs/concepts/overview/components.md to match latest en contents

@k8s-ci-robot k8s-ci-robot changed the title [ko] Sync/ko/docs/concepts/overview/components.md to match latest en contents [ko] Sync /ko/docs/concepts/overview/components.md to match latest en contents Sep 10, 2025
@ianychoi
Copy link
Member

/lgtm

@jongwooo Any other feedback than your latest change on the title? Thanks in advance.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 41c9a06bf9c18ea24bbcbdde1a573174cf03966e

@jongwooo
Copy link
Member

Hi @wonyongg,

To finalize this PR, please squash commits of this PR into one commit.

@wonyongg
sync-ko-overview-components.md
e6a8baa 
Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

Co-authored-by: Jongwoo Han <[email protected]>

Address review comments

address review comments

address review comments
@wonyongg wonyongg force-pushed the sync-ko-overview-components.md branch from e4bcc18 to e6a8baa Compare September 20, 2025 10:55
jongwooo
jongwooo reviewed Sep 20, 2025
View reviewed changes
Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5793853 into kubernetes:main Sep 20, 2025
6 checks passed
@wonyongg wonyongg deleted the sync-ko-overview-components.md branch September 20, 2025 11:25
@ianychoi ianychoi mentioned this pull request Sep 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo

3 more reviewers

@jongwooo jongwooo jongwooo left review comments

@ianychoi ianychoi ianychoi requested changes

@Eundms Eundms Eundms requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ianychoi ianychoi

@jongwooo jongwooo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ko] Update /ko/docs/concepts/overview/components.md to match en contents

5 participants

@wonyongg @jongwooo @ianychoi @k8s-ci-robot @Eundms