Skip to content

Conversation

alikhere
Copy link
Contributor

@alikhere alikhere commented Sep 18, 2025

fix cel expression in content/zh-cn/examples/dra/resourceclaimtemplate.yaml
sync with #52338

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization labels Sep 18, 2025
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2025
Copy link

netlify bot commented Sep 18, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ee0b4e4
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68cdc8e6216d7f0008e821b0
😎 Deploy Preview https://deploy-preview-52409--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Hi @alikhere, you need to change the english upstream first before change the zh version.

Also, this zh file has some more insynced content:

./scripts/lsync.sh content/zh-cn/examples/dra/resourceclaimtemplate.yaml
diff --git a/content/en/examples/dra/resourceclaimtemplate.yaml b/content/en/examples/dra/resourceclaimtemplate.yaml
index 83e9c63b1b..1a604e102e 100644
--- a/content/en/examples/dra/resourceclaimtemplate.yaml
+++ b/content/en/examples/dra/resourceclaimtemplate.yaml
@@ -1,4 +1,4 @@
-apiVersion: resource.k8s.io/v1beta2
+apiVersion: resource.k8s.io/v1
 kind: ResourceClaimTemplate
 metadata:
   name: example-resource-claim-template

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2025
@alikhere alikhere force-pushed the docs/zn-cn-fix-resourceclaimtemplate.yaml branch from a7b1208 to ee0b4e4 Compare September 19, 2025 21:19
@alikhere
Copy link
Contributor Author

alikhere commented Sep 19, 2025

@windsonsea synced apiVersion too and PR for en has already been raise #52338 waiting to get merge

@tengqm
Copy link
Contributor

tengqm commented Sep 21, 2025

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 069f3aa7c9c6ae3632f105674a55feba9fa6ea55

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 68124a7 into kubernetes:main Sep 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants