-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[zh-cn] Delete redundant comments to fix rendering issues. #52419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @duzhuoshanwai! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
It's not correct to remove all commented text. You need to figure out which lines cause the issue.
For example, this shortcode structure is not suitable to add the commented text:
{{< glossary_definition prepend="The Container Runtime Interface (CRI) is" term_id="cri" length="all" >}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. See preview:
https://deploy-preview-52419--kubernetes-io-main-staging.netlify.app/zh-cn/docs/concepts/architecture/cri/
You need to squash your commits into a single one. Refer to:
https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits
/unhold |
/lgtm |
LGTM label has been added. Git tree hash: a110da457d42256b9f1b063137b0157c0e304ce5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
https://kubernetes.io/zh-cn/docs/concepts/architecture/cri/ Delete redundant comments and fixed the rendering issues.
Issue
Closes: #