Skip to content

Conversation

asimuleo
Copy link
Contributor

@asimuleo asimuleo commented Sep 23, 2025

Description

This PR fixes broken link to the guestbook example in the following document:
content/en/docs/concepts/overview/working-with-objects/labels.md

The original link was pointing to the /guestbook directory, which has now been moved to /web/guestbook

https://github.com/kubernetes/examples/tree/master/guestbook/
These have been updated to point to the correct path:

https://github.com/kubernetes/examples/tree/master/guestbook/

Issue

no issue found

Closes: #

Copy link

linux-foundation-easycla bot commented Sep 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: asimuleo / name: ImHyuk (67ca9a9)

@k8s-ci-robot
Copy link
Contributor

Welcome @asimuleo!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 23, 2025
Copy link

netlify bot commented Sep 23, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 67ca9a9
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68d3c658d0be770008d5cfed
😎 Deploy Preview https://deploy-preview-52498--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@windsonsea
Copy link
Member

Hi @asimuleo , please only update the english version in this PR.
zh and more localization variants can be handled by different teams.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2025
@asimuleo
Copy link
Contributor Author

Hi @windsonsea, I update this PR. Thank you!

@stmcginnis
Copy link
Contributor

Link goes to correct place now, and only includes English changes.

/remove-language zh
/lgtm

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label Sep 24, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d7fedb86de6e6fca783c04846391dacd7184d815

@dipesh-rawat
Copy link
Member

/unhold
/remove-area localization

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/localization General issues or PRs related to localization labels Sep 28, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 05afda1 into kubernetes:main Sep 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants