Skip to content

Conversation

dkarczmarski
Copy link
Contributor

@dkarczmarski dkarczmarski commented Sep 25, 2025

  1. change type "shell" to "console" because it is an output . I changed it to "console" only because in the previous part of this file the author used "console".
  2. replace "this page" with "Service" - according to : https://kubernetes.io/docs/contribute/style/style-guide/#links .

... or maybe instead "Service" we can use "Service.Type=LoadBalancer" - the same as on https://kubernetes.io/docs/concepts/services-networking/ingress/#alternatives

@k8s-ci-robot k8s-ci-robot requested a review from lmktfy September 25, 2025 17:08
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 25, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2025
Copy link

netlify bot commented Sep 25, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f6dfaf0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68d8f46b5872820008233b28
😎 Deploy Preview https://deploy-preview-52526--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@windsonsea
Copy link
Member

Hi @dkarczmarski, please squash your commits into a single one. Refer to:
https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits

@dkarczmarski dkarczmarski force-pushed the fix-typo-expose-external-ip-address branch from d7b6fa8 to f6dfaf0 Compare September 28, 2025 08:40
@dkarczmarski
Copy link
Contributor Author

@windsonsea
squashed

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3a89498ec6639371a6f77476a1c86bfaa562b732

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 94c5249 into kubernetes:main Sep 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants