Skip to content

Conversation

lmktfy
Copy link
Contributor

@lmktfy lmktfy commented Sep 30, 2025

Rather than a hard coded list, use the algorithm that Docsy uses.

Helps with issues #41171 and #50228

Original vs preview (there is a change to the link text for our blog, but I think it's an improvement)

/hold

Do not merge until PR #52595 has merged.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2025
@lmktfy
Copy link
Contributor Author

lmktfy commented Sep 30, 2025

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Sep 30, 2025
Copy link

netlify bot commented Sep 30, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8e40279
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68e576381d5abf00088e1532
😎 Deploy Preview https://deploy-preview-52596--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Contributor Author

lmktfy commented Oct 2, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2025
@lmktfy lmktfy force-pushed the 20250930_adapt_menus branch from 4cc761a to 5f628e2 Compare October 6, 2025 17:44
lmktfy added 2 commits October 7, 2025 21:16
Rather than a hard coded list, use the algorithm that Docsy uses.
@lmktfy lmktfy force-pushed the 20250930_adapt_menus branch from 5f628e2 to 8e40279 Compare October 7, 2025 20:21
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sayakmukhopadhyay for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andygol
Copy link
Contributor

Andygol commented Oct 11, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 923b868f6eb1fe47cb1d47103ef298ddff7c0f8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants