Skip to content

[ko] Update /docs/concepts/workloads/controllers/deployment #52600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

[ko] Update /docs/concepts/workloads/controllers/deployment #52600

merged 1 commit into from
Oct 15, 2025
+502 −362

Conversation

Eundms
Copy link
Member

@Eundms Eundms commented Oct 2, 2025

Description

  • Update /ko/docs/concepts/workloads/controllers/deployment.md because it is outdated

Issue

#52551

Closes: #52551

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ianychoi October 2, 2025 06:30
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Oct 2, 2025
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 2, 2025
@netlify Netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 874e37b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68ef795de431cf0008835591
😎 Deploy Preview https://deploy-preview-52600--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

ianychoi
ianychoi suggested changes Oct 14, 2025
View reviewed changes
Copy link
Member

@ianychoi ianychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

긴 문서에 대해 접근해주셔서 감사합니다. 개선 요청드립니다.

content/ko/docs/concepts/workloads/controllers/deployment.md Outdated
`nginx-deployment` 이름을 가진 디플로이먼트가 생성된다. 이 이름은 이후에 생성되는
레플리카셋과 파드의 기준이 된다. 더 많은 정보를 위해 [디플로이먼트 명세 작성](#디플로이먼트-명세-작성)를
참고한다.
* `.spec.replicas` 필드에 따라 디플로이먼트는 3개의 레플리카 파드를 생성하는 레플리카셋을 생성한다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

영어 원문에 replicated로 되어 있는 것을 레플리카로 번역하는 것은 적절하지 않습니다. 고쳐주세요. 예시: "복제된 파드 3개를 생성하는 레플리카셋을 생성한다"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

또한 영어는 creates.. that creates로 나와 있는데 생성한다가 2번 나오니 조금 어색해서, 앞 부분을 "만드는" 정도로 의역해도 좋겠습니다.

content/ko/docs/concepts/workloads/controllers/deployment.md Outdated
```
여기서 `deployment/nginx-deployment`는 디플로이먼트를 나타내며,
nginx는 업데이트가 이루어질 컨테이너를 나타내고,
`nginx:1.16.1`은 새로운 이미지와 그 태그를 나타낸다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"its tag"를 "그 태그"로 직역하니 어색합니다. 또한 indicates를 나타낸다고 하니 이상해요. 약간 의역을 하는 걸로 하시죠. 개선 예시: "nginx:1.16.1은 새 이미지와 태그 값을 가리킨다."

   여기서 `deployment/nginx-deployment`는 디플로이먼트를,
   nginx는 업데이트가 이루어질 컨테이너를,
   그리고 `nginx:1.16.1`은 새 이미지와 태그 값을 가리킨다.

@Eundms
Copy link
Member Author

Eundms commented Oct 14, 2025

긴 문서에 대해 접근해주셔서 감사합니다. 개선 요청드립니다.

@ianychoi 리뷰 감사합니다. 개선 사항 반영하였습니다. 확인 부탁드립니다. : )

@ianychoi
Copy link
Member

/lgtm

@jongwooo PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5f2339fcf0e900e45411d8d43b106258f7a26e9

@jongwooo
Copy link
Member

Hi @Eundms

To finalize this PR, please squash commits of this PR into one commit.

@Eundms Eundms force-pushed the ko/concepts-workloads-controllers-deployment branch from 7bfcbfa to 874e37b Compare October 15, 2025 10:37
jongwooo
jongwooo reviewed Oct 15, 2025
View reviewed changes
Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0f1ab00 into kubernetes:main Oct 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seokho-son seokho-son Awaiting requested review from seokho-son

2 more reviewers

@jongwooo jongwooo jongwooo left review comments

@ianychoi ianychoi ianychoi requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ianychoi ianychoi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ko] Update /docs/concepts/workloads/controllers/deployment.md

4 participants

@Eundms @ianychoi @k8s-ci-robot @jongwooo