Skip to content

Conversation

shivansh-gohem
Copy link

Fixes #52516

Summary of Change

This Pull Request improves the clarity and referenceability of the "Node Status" documentation by adding explicit links to the configuration parameters for the two key timing values mentioned in the "Heartbeats" section.

Details of the Fix

The paragraph previously stated the default times (5 minutes for Kubelet updates and 40 seconds for unreachability) without explaining how to change them.

The updated text now links directly to the relevant documentation pages:

  • Kubelet Update Interval: Links to the Kubelet configuration task page for adjusting the nodeStatusUpdateFrequency.
  • Node Controller Timeout: Links to the kube-controller-manager reference page for the --node-monitor-grace-period flag.

This resolves the long-standing request for better configuration guidance on this page.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tengqm October 3, 2025 17:37
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 3, 2025
@shivansh-gohem
Copy link
Author

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 3, 2025
Copy link

netlify bot commented Oct 3, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 95124b6
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68e009d66128d60008ecb830
😎 Deploy Preview https://deploy-preview-52621--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shivansh-gohem shivansh-gohem force-pushed the fix-node-status-links branch 2 times, most recently from 918e2a6 to 72602e1 Compare October 3, 2025 17:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 3, 2025
Copy link

netlify bot commented Oct 3, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4301ed2
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68e00bc4d05aa500089a1f18
😎 Deploy Preview https://deploy-preview-52621--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 3, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 72602e1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68e00cbe10850b0008650122
😎 Deploy Preview https://deploy-preview-52621--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/reference/node/node-status/
2 participants