Skip to content

Add support for direct DNS lookups behind a feature flag. #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

YoEight
Copy link
Member

@YoEight YoEight commented Oct 6, 2024

Added: Add support for direct DNS lookups behind a feature flag.

Fixes #273

description

With this feature, the client will directly perform DNS lookups when probing for candidates during the connection process to a cluster of nodes. This mirrors the behavior from when the TCP API was still supported.

You can enable that feature using a connection string or a the connection builder.

connection string

esdb+discover://my.esdbcluster.com:1234?feature=dns-lookup

connection builder

     EventStoreDBClientSettings.builder()
        .dnsDiscover(true)
        .addHost("my.esdbcluster.com", 1234)
        .feature("dns-lookup")
        .buildConnectionSettings()

@YoEight YoEight force-pushed the yoeight/dns-lookup-feature branch from 88daa6c to b3668e1 Compare October 7, 2024 14:31
@YoEight YoEight merged commit 911927f into trunk Oct 7, 2024
39 checks passed
@YoEight YoEight deleted the yoeight/dns-lookup-feature branch October 7, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should DNS discovery use all IPs in a multi-address DNS name as cluster seeds?
3 participants