-
Notifications
You must be signed in to change notification settings - Fork 661
Upgrade to Dotnet SDK 3.1.201 #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
203a062
to
1572531
Compare
Spoke too soon.. the same tests are failing. |
1572531
to
bc6b29c
Compare
a7b403a
to
ee10f1a
Compare
ec1c112
to
f088e19
Compare
bdc895f
to
4926d1b
Compare
a57ff3e
to
ba9a55c
Compare
Closed
ba9a55c
to
f3ce8de
Compare
be61ce7
to
dbeb7d1
Compare
mat-mcloughlin
previously approved these changes
Mar 23, 2020
shaan1337
requested changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline:
- .NET Core 3.1.3 is out since yesterday and we need to upgrade some of the dependencies from 3.1.2 to 3.1.3.
- The .NET SDK used for builds in ci.yml can also optionally be upgraded to the latest version, currently 3.1.102 is being used.
dbeb7d1
to
9f499a4
Compare
shaan1337
reviewed
Mar 26, 2020
9f499a4
to
22866af
Compare
shaan1337
approved these changes
Mar 27, 2020
jageall
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: updated to dotnet sdk 3.1.201
dotnet 3.1.2 came out yesterday, which includes dotnet/aspnetcore#17158. This will obviate the need to stand up kestrel when we test anything that uses BiD streaming.