Skip to content

Upgrade to Dotnet SDK 3.1.201 #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Conversation

thefringeninja
Copy link
Contributor

@thefringeninja thefringeninja commented Feb 20, 2020

Changed: updated to dotnet sdk 3.1.201

dotnet 3.1.2 came out yesterday, which includes dotnet/aspnetcore#17158. This will obviate the need to stand up kestrel when we test anything that uses BiD streaming.

@thefringeninja thefringeninja self-assigned this Feb 20, 2020
@thefringeninja thefringeninja added this to the Event Store V6 Preview 3 milestone Feb 20, 2020
@thefringeninja
Copy link
Contributor Author

Spoke too soon.. the same tests are failing.

@thefringeninja thefringeninja changed the title Upgrade Depenencies Upgrade Dependencies Feb 20, 2020
@thefringeninja thefringeninja marked this pull request as ready for review March 2, 2020 16:40
@thefringeninja thefringeninja force-pushed the dotnet-3.1.2 branch 3 times, most recently from ec1c112 to f088e19 Compare March 4, 2020 08:53
@mat-mcloughlin mat-mcloughlin modified the milestones: Event Store V6 Preview 3, EventStore 20.02 RC Mar 4, 2020
@thefringeninja thefringeninja force-pushed the dotnet-3.1.2 branch 6 times, most recently from bdc895f to 4926d1b Compare March 6, 2020 09:21
@thefringeninja thefringeninja modified the milestones: EventStore 20.02 RC, Event Store V6 Preview 3 Mar 6, 2020
@thefringeninja thefringeninja force-pushed the dotnet-3.1.2 branch 4 times, most recently from a57ff3e to ba9a55c Compare March 9, 2020 09:51
@thefringeninja thefringeninja modified the milestones: Event Store V6 Preview 3, EventStore 20.02 RC Mar 9, 2020
@thefringeninja thefringeninja linked an issue Mar 9, 2020 that may be closed by this pull request
@thefringeninja thefringeninja force-pushed the dotnet-3.1.2 branch 3 times, most recently from be61ce7 to dbeb7d1 Compare March 19, 2020 12:54
mat-mcloughlin
mat-mcloughlin previously approved these changes Mar 23, 2020
@mat-mcloughlin mat-mcloughlin requested review from shaan1337 and removed request for jageall March 24, 2020 11:18
Copy link
Member

@shaan1337 shaan1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline:

  • .NET Core 3.1.3 is out since yesterday and we need to upgrade some of the dependencies from 3.1.2 to 3.1.3.
  • The .NET SDK used for builds in ci.yml can also optionally be upgraded to the latest version, currently 3.1.102 is being used.

@jageall jageall requested review from jageall and removed request for mat-mcloughlin March 27, 2020 11:08
@thefringeninja thefringeninja changed the title Upgrade Dependencies Upgrade to Dotnet SDK 3.1.201 Mar 30, 2020
@jageall jageall merged commit 72c10bf into kurrent-io:master Mar 30, 2020
@thefringeninja thefringeninja deleted the dotnet-3.1.2 branch March 31, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dependencies
4 participants