This repository was archived by the owner on Apr 22, 2024. It is now read-only.
Issue #113 google style #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| message_type = header.message_type | ||
| if not isinstance(message_type, Type): | ||
| try: | ||
| if isinstance(message_type, str): | ||
| message_type = Type[message_type] |
There was a problem hiding this comment.
Probably you introduced a bug. message_type here is a string:
message_type = Type("OFPT_HELLO")
ValueError: 'OFPT_HELLO' is not a valid TypePlease check this with @diraol to make sure that this way is right.
There was a problem hiding this comment.
You are right. It was a false positive from pylint (pylint-dev/pylint#992). I reverted it and rebased.
Foundation module: - Converted docstring to Google-style; - Reduced linter messages. Close #113
cemsbr
force-pushed
the
issue-#113-google-style
branch
from
be52575 to
47f7907
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.