-
Notifications
You must be signed in to change notification settings - Fork 9
Add type annotation pattern #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
Can you please add an example to the documentation as well?
Also, the Travis build fails on Rust 1.7.0. Can you please investigate? I'm happy to bump the minimum supported version, but I'd like to know the reason behind the error first. Thanks! |
@lfairy sorry for the delay, I've updated the PR. |
Thanks for looking into it. I played around with the build and found that Rust 1.11.0 works but 1.10.0 doesn't. I'm happy with bumping the version requirement to 1.11.0.
That issue probably isn't relevant because it was fixed in 2014 when 1.11.0 was released in 2016. Looking at the release notes, rust-lang/rust#34436 feels more likely. I found that Can you please bump the minimum version to 1.11.0 and add an example to the documentation? Once that's done then I'll be happy to merge. |
@tathanhdinh are you still working on this PR? I would like to get this merged because I have a PR idea that touches your code along with other parts of |
Sorry, I forgot it. I will push the changed PR today. |
Sorry about the delay! Looks good to me. |
Simple change to handle #5