Skip to content

[starkware-development] Pin types-rs version to the one set in lockfile #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gabrielbosio
Copy link
Collaborator

No description provided.

Copy link

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     25.926 s ±  0.050 s    [User: 25.074 s, System: 0.848 s]
  Range (min … max):   25.891 s … 25.962 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     25.678 s ±  0.009 s    [User: 24.814 s, System: 0.861 s]
  Range (min … max):   25.672 s … 25.685 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.437 s ±  0.019 s    [User: 25.232 s, System: 0.875 s]
  Range (min … max):   14.424 s … 14.450 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.962 s ±  0.004 s    [User: 24.855 s, System: 0.920 s]
  Range (min … max):   13.959 s … 13.965 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.03 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.913 s ±  0.020 s    [User: 37.576 s, System: 1.069 s]
  Range (min … max):   10.899 s … 10.927 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.122 s ±  0.019 s    [User: 37.365 s, System: 1.171 s]
  Range (min … max):   10.108 s … 10.135 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.08 ± 0.00 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.504 s ±  0.234 s    [User: 38.180 s, System: 1.106 s]
  Range (min … max):   10.339 s … 10.670 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.419 s ±  0.010 s    [User: 37.132 s, System: 1.185 s]
  Range (min … max):   10.412 s … 10.426 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.451 s ±  0.311 s    [User: 38.359 s, System: 1.119 s]
  Range (min … max):   10.231 s … 10.672 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.116 s ±  0.053 s    [User: 37.665 s, System: 1.249 s]
  Range (min … max):   10.079 s … 10.154 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.03 ± 0.03 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.373 s ±  0.226 s    [User: 38.853 s, System: 1.167 s]
  Range (min … max):   10.213 s … 10.533 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.053 s ±  0.072 s    [User: 37.998 s, System: 1.282 s]
  Range (min … max):   10.002 s … 10.104 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.03 ± 0.02 times faster than hyper_threading_main threads: 16


Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.182 ± 0.069 2.150 2.379 1.01 ± 0.03
head big_factorial 2.162 ± 0.007 2.153 2.173 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.084 ± 0.008 2.070 2.094 1.00 ± 0.01
head big_fibonacci 2.080 ± 0.018 2.061 2.120 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.649 ± 0.098 7.545 7.835 1.00 ± 0.01
head blake2s_integration_benchmark 7.648 ± 0.050 7.548 7.727 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.235 ± 0.009 2.224 2.254 1.00
head compare_arrays_200000 2.245 ± 0.012 2.224 2.264 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.461 ± 0.006 1.454 1.473 1.00 ± 0.01
head dict_integration_benchmark 1.457 ± 0.007 1.449 1.470 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.251 ± 0.009 1.242 1.272 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.243 ± 0.005 1.236 1.248 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.766 ± 0.052 7.710 7.855 1.00 ± 0.01
head integration_builtins 7.749 ± 0.051 7.644 7.830 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.032 ± 0.212 7.873 8.534 1.02 ± 0.03
head keccak_integration_benchmark 7.912 ± 0.082 7.848 8.073 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.205 ± 0.007 2.196 2.215 1.00 ± 0.01
head linear_search 2.194 ± 0.021 2.170 2.237 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.543 ± 0.015 1.534 1.576 1.00 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.542 ± 0.019 1.531 1.594 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.481 ± 0.006 1.469 1.488 1.00
head math_integration_benchmark 1.491 ± 0.004 1.485 1.500 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.232 ± 0.016 1.221 1.274 1.00
head memory_integration_benchmark 1.233 ± 0.003 1.228 1.236 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.571 ± 0.013 1.561 1.602 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.568 ± 0.006 1.558 1.577 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 538.8 ± 1.6 536.7 541.4 1.00 ± 0.00
head pedersen 538.2 ± 1.3 536.4 540.3 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 640.6 ± 1.9 638.1 644.1 1.00
head poseidon_integration_benchmark 642.4 ± 15.0 632.5 684.6 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.864 ± 0.014 1.845 1.887 1.00
head secp_integration_benchmark 1.867 ± 0.016 1.851 1.900 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 690.6 ± 5.2 683.6 699.4 1.00 ± 0.01
head set_integration_benchmark 687.3 ± 5.4 682.0 699.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.346 ± 0.020 4.329 4.383 1.00 ± 0.02
head uint256_integration_benchmark 4.333 ± 0.071 4.266 4.512 1.00

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (b6c2f5a) to head (5227bd4).
Report is 1 commits behind head on starkware-development.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           starkware-development    #2142   +/-   ##
======================================================
  Coverage                  96.63%   96.63%           
======================================================
  Files                        104      104           
  Lines                      43904    43904           
======================================================
  Hits                       42428    42428           
  Misses                      1476     1476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabrielbosio gabrielbosio marked this pull request as ready for review July 23, 2025 21:03
@YairVaknin-starkware YairVaknin-starkware self-requested a review July 24, 2025 10:24
@YairVaknin-starkware YairVaknin-starkware merged commit df70ca8 into starkware-development Jul 24, 2025
94 checks passed
@YairVaknin-starkware YairVaknin-starkware deleted the pin_types_rs_version_strk_dev branch July 24, 2025 10:25
gabrielbosio added a commit that referenced this pull request Jul 31, 2025
…le (#2142)

* Update changelog

* Pin types-rs version
gabrielbosio added a commit that referenced this pull request Jul 31, 2025
…le (#2142)

* Update changelog

* Pin types-rs version
gabrielbosio added a commit that referenced this pull request Jul 31, 2025
…le (#2142)

* Update changelog

* Pin types-rs version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants