-
Notifications
You must be signed in to change notification settings - Fork 49
Add blockifier tests to the ci #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.424 ± 0.038 | 11.392 | 11.528 | 2.18 ± 0.02 |
cairo-native (embedded AOT) |
5.248 ± 0.051 | 5.171 | 5.338 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.266 ± 0.034 | 5.215 | 5.313 | 1.00 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
846.4 ± 8.5 | 835.1 | 856.5 | 1.00 |
cairo-native (embedded AOT) |
5147.7 ± 49.7 | 5043.9 | 5207.1 | 6.08 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5124.9 ± 35.0 | 5070.5 | 5177.7 | 6.05 ± 0.07 |
Benchmark for program factorial_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.313 ± 0.056 | 5.261 | 5.462 | 1.00 |
cairo-native (embedded AOT) |
5.531 ± 0.093 | 5.365 | 5.688 | 1.04 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.507 ± 0.044 | 5.439 | 5.561 | 1.04 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.125 ± 0.021 | 5.090 | 5.165 | 1.00 |
cairo-native (embedded AOT) |
5.154 ± 0.087 | 5.021 | 5.293 | 1.01 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.190 ± 0.051 | 5.122 | 5.278 | 1.01 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
851.7 ± 8.0 | 839.3 | 865.8 | 1.00 |
cairo-native (embedded AOT) |
5147.2 ± 37.0 | 5090.3 | 5206.6 | 6.04 ± 0.07 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5253.4 ± 56.2 | 5176.2 | 5358.7 | 6.17 ± 0.09 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
542.5 ± 7.4 | 532.6 | 552.5 | 1.00 |
cairo-native (embedded AOT) |
5047.5 ± 29.9 | 5000.4 | 5103.8 | 9.30 ± 0.14 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5363.0 ± 94.6 | 5242.9 | 5535.2 | 9.89 ± 0.22 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 111 111
Lines 30441 30441
=======================================
Hits 24106 24106
Misses 6335 6335 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ative into add-blockifier-tests
97f2d59
to
ebfdc99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before merging, we should check if this is still working for newer versiones of the blockifier. I seem to remember that new tests were added, which depend on the starknet os. This means we would need to build it in order for the tests to able to execute correctly. |
We've recently had an issue when running blockifier's tests with native. This PR adds those to the ci so as to have that checked (Only for linux).
Checklist