Skip to content

Conversation

FrancoGiachetta
Copy link
Contributor

We've recently had an issue when running blockifier's tests with native. This PR adds those to the ci so as to have that checked (Only for linux).

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Apr 11, 2025

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 5.332 ± 0.054 5.259 5.441 1.01 ± 0.02
base dict_insert.cairo (AOT) 5.298 ± 0.069 5.185 5.431 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 5.329 ± 0.054 5.266 5.445 1.02 ± 0.02
head dict_insert.cairo (AOT) 5.230 ± 0.060 5.155 5.364 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 5.092 ± 0.037 5.024 5.149 1.03 ± 0.01
base dict_snapshot.cairo (AOT) 4.955 ± 0.043 4.867 5.037 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 5.058 ± 0.045 4.996 5.146 1.02 ± 0.01
head dict_snapshot.cairo (AOT) 4.943 ± 0.032 4.902 5.014 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 5.419 ± 0.047 5.366 5.517 1.01 ± 0.01
base factorial_2M.cairo (AOT) 5.365 ± 0.044 5.327 5.470 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 5.395 ± 0.030 5.354 5.453 1.00 ± 0.01
head factorial_2M.cairo (AOT) 5.391 ± 0.027 5.349 5.420 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 4.936 ± 0.037 4.874 4.979 1.00 ± 0.01
base fib_2M.cairo (AOT) 4.930 ± 0.045 4.839 4.981 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 4.931 ± 0.033 4.909 5.013 1.01 ± 0.01
head fib_2M.cairo (AOT) 4.889 ± 0.046 4.840 4.983 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 5.262 ± 0.303 5.079 6.109 1.06 ± 0.06
base linear_search.cairo (AOT) 4.966 ± 0.027 4.935 5.010 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 5.148 ± 0.036 5.081 5.200 1.03 ± 0.01
head linear_search.cairo (AOT) 4.997 ± 0.035 4.961 5.065 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 5.220 ± 0.053 5.163 5.314 1.03 ± 0.01
base logistic_map.cairo (AOT) 5.049 ± 0.047 4.969 5.134 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 5.296 ± 0.060 5.197 5.369 1.04 ± 0.01
head logistic_map.cairo (AOT) 5.109 ± 0.041 5.047 5.191 1.00

Copy link

github-actions bot commented Apr 11, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.424 ± 0.038 11.392 11.528 2.18 ± 0.02
cairo-native (embedded AOT) 5.248 ± 0.051 5.171 5.338 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 5.266 ± 0.034 5.215 5.313 1.00 ± 0.01

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 846.4 ± 8.5 835.1 856.5 1.00
cairo-native (embedded AOT) 5147.7 ± 49.7 5043.9 5207.1 6.08 ± 0.08
cairo-native (embedded JIT using LLVM's ORC Engine) 5124.9 ± 35.0 5070.5 5177.7 6.05 ± 0.07

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.313 ± 0.056 5.261 5.462 1.00
cairo-native (embedded AOT) 5.531 ± 0.093 5.365 5.688 1.04 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 5.507 ± 0.044 5.439 5.561 1.04 ± 0.01

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.125 ± 0.021 5.090 5.165 1.00
cairo-native (embedded AOT) 5.154 ± 0.087 5.021 5.293 1.01 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 5.190 ± 0.051 5.122 5.278 1.01 ± 0.01

Benchmark for program linear_search

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 851.7 ± 8.0 839.3 865.8 1.00
cairo-native (embedded AOT) 5147.2 ± 37.0 5090.3 5206.6 6.04 ± 0.07
cairo-native (embedded JIT using LLVM's ORC Engine) 5253.4 ± 56.2 5176.2 5358.7 6.17 ± 0.09

Benchmark for program logistic_map

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 542.5 ± 7.4 532.6 552.5 1.00
cairo-native (embedded AOT) 5047.5 ± 29.9 5000.4 5103.8 9.30 ± 0.14
cairo-native (embedded JIT using LLVM's ORC Engine) 5363.0 ± 94.6 5242.9 5535.2 9.89 ± 0.22

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.18%. Comparing base (21cc66c) to head (9a35181).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1176   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files         111      111           
  Lines       30441    30441           
=======================================
  Hits        24106    24106           
  Misses       6335     6335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JulianGCalderon JulianGCalderon marked this pull request as draft May 5, 2025 15:22
@FrancoGiachetta FrancoGiachetta marked this pull request as ready for review July 17, 2025 16:48
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrancoGiachetta
Copy link
Contributor Author

FrancoGiachetta commented Aug 5, 2025

Before merging, we should check if this is still working for newer versiones of the blockifier. I seem to remember that new tests were added, which depend on the starknet os. This means we would need to build it in order for the tests to able to execute correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants