Skip to content

perf(l1): filter empty storages from snapshots #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

perf(l1): filter empty storages from snapshots #4590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13da109
perf(l1): filter empty storages from snapshots
Oppen Sep 20, 2025
eaa0368
Merge branch 'main' into perf/filter_empty_storages
Oppen Sep 24, 2025
85c1839
changelog
Oppen Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Perf

### 2025-09-24

- Avoid dumping empty storage accounts to disk [#4590](https://github.com/lambdaclass/ethrex/pull/4590)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this needs more context

Suggested change
- Avoid dumping empty storage accounts to disk [#4590](https://github.com/lambdaclass/ethrex/pull/4590)
- Avoid dumping empty storage accounts to disk during snap sync [#4590](https://github.com/lambdaclass/ethrex/pull/4590)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1



### 2025-09-22

Expand Down
2 changes: 2 additions & 0 deletions crates/networking/p2p/peer_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,7 @@ impl PeerHandler {
.clone()
.into_iter()
.zip(current_account_storages)
.filter(|(_, storages)| !storages.is_empty())
.collect::<Vec<_>>()
.encode_to_vec();

Expand Down Expand Up @@ -1569,6 +1570,7 @@ impl PeerHandler {
let snapshot = current_account_hashes
.into_iter()
.zip(current_account_storages)
.filter(|(_, storages)| !storages.is_empty())
.collect::<Vec<_>>()
.encode_to_vec();

Expand Down
Loading