feat(l2): add verification key upgrade functions #4611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to upgrade SP1 and RISC0 verification keys in the OnChainProposer contracts without requiring a full UUPS contract upgrade.
- Adds two new functions to upgrade verification keys for SP1 and RISC0 zkVMs independently
- Implements the functions in both standard and based OnChainProposer contracts with proper access control
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/l2/contracts/src/l1/interfaces/IOnChainProposer.sol | Adds interface declarations for SP1 and RISC0 verification key upgrade functions |
| crates/l2/contracts/src/l1/based/interfaces/IOnChainProposer.sol | Adds interface declarations for SP1 and RISC0 verification key upgrade functions (based variant) |
| crates/l2/contracts/src/l1/based/OnChainProposer.sol | Implements verification key upgrade functions with owner-only access control (based variant) |
| crates/l2/contracts/src/l1/OnChainProposer.sol | Implements verification key upgrade functions with owner-only access control |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crates/l2/contracts/src/l1/based/interfaces/IOnChainProposer.sol
Outdated
Show resolved
Hide resolved
crates/l2/contracts/src/l1/based/interfaces/IOnChainProposer.sol
Outdated
Show resolved
Hide resolved
ilitteri
approved these changes
Sep 23, 2025
jrchatruc
reviewed
Sep 23, 2025
|
|
||
| /// @inheritdoc IOnChainProposer | ||
| function upgradeSP1VerificationKey(bytes32 new_vk) public onlyOwner { | ||
| SP1_VERIFICATION_KEY = new_vk; |
There was a problem hiding this comment.
Let's emit an event here after setting it (same for RISC0 and the non-based cases)
|
I created an issue to document this process along with other upgrades |
jrchatruc
approved these changes
Sep 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when someone wants to upgrade the ethrex version of an L2, they have to perform an UUPS upgrade to the contract in order to upgrade the verification keys.
Description
Add a function to upgrade SP1 and RISC0 VKs without the need of a full upgrade to the contract