Skip to content

Conversation

cdiielsi
Copy link
Contributor

@cdiielsi cdiielsi commented Sep 23, 2025

Motivation

Hive test Invalid Missing Ancestor Syncing ReOrg, Transaction Nonce, EmptyTxs=False, CanonicalReOrg=True, Invalid P9 (Cancun) has been detected as flaky in different prs (here and here) but logs aren't specific on why the test failed. In this pr I had the test in question run several times but it never failed, so there was no way to figure out why it is flaky. Having the ci show more specific logs should be useful to have more information on flaky tests for any pr and any test.

Description

Set --docker.output for running the hive tests on the ci.

Closes no issue but it's related to #3105

@github-actions github-actions bot added the L1 Ethereum client label Sep 23, 2025
Copy link

Lines of code report

Total lines added: 0
Total lines removed: 15
Total lines changed: 15

Detailed view
+--------------------------------------+-------+------+
| File                                 | Lines | Diff |
+--------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync.rs | 1201  | -15  |
+--------------------------------------+-------+------+

@cdiielsi cdiielsi marked this pull request as ready for review September 24, 2025 15:35
@cdiielsi cdiielsi requested a review from a team as a code owner September 24, 2025 15:35
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Sep 24, 2025
Copy link
Contributor

@SDartayet SDartayet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SDartayet SDartayet added this pull request to the merge queue Sep 24, 2025
Merged via the queue into main with commit a454c47 Sep 24, 2025
44 checks passed
@SDartayet SDartayet deleted the set_docker_output_for_ci_hive branch September 24, 2025 22:15
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L1 Ethereum client
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants