Skip to content

cores.mech: Add Endless Potentiometer Decoder #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/python-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
build:

runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v4
Expand Down
243 changes: 243 additions & 0 deletions lambdalib/cores/mech/endless_potentiometer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,243 @@
# Endless potentiometer decoding into relative rotation
# 2025 - LambdaConcept <[email protected]>
from amaranth import *
from ...interface import stream

__all__ = ["EndlessPotentiometerDecoder"]


class _ThresholdDetector(Elaboratable):
"""Detects when a value changes above/below a threshold"""
def __init__(self, width, threshold, id_width=0):
self._width = width
self._threshold = threshold

self.readout = stream.Endpoint([
("id", id_width),
("value", width),
("previous_value", width),
])

self.detection = stream.Endpoint([
("id", id_width),
("up", 1),
("down", 1),
("value", width), # Readout value passthrough
("delta", signed(width + 1)), # value - previous_value
])

def elaborate(self, platform):
m = Module()

low_threshold = Signal(signed(self._width + 1))
high_threshold = Signal(signed(self._width + 1))
m.d.comb += [
low_threshold.eq(self.readout.previous_value - self._threshold),
high_threshold.eq(self.readout.previous_value + self._threshold),
]

with m.If(self.detection.ready | ~self.detection.valid):
m.d.sync += [
self.detection.valid.eq(self.readout.valid),
self.detection.up.eq(self.readout.value > high_threshold),
self.detection.down.eq(self.readout.value < low_threshold),
self.detection.value.eq(self.readout.value),
self.detection.delta.eq(self.readout.value - self.readout.previous_value),
self.detection.id.eq(self.readout.id),
]
m.d.comb += self.readout.ready.eq(self.detection.ready | ~self.detection.valid)

return m


class _DirectionDecoding(Elaboratable):
def __init__(self, width, id_width=0):
self._width = width

self.dir_a = stream.Endpoint([
("id", id_width),
("up", 1),
("down", 1),
("value", width),
("delta", signed(width + 1)),
])
self.dir_b = stream.Endpoint([
("id", id_width),
("up", 1),
("down", 1),
("value", width),
("delta", signed(width + 1)),
])

self.direction = stream.Endpoint([
("id", id_width),
("clockwise", 1),
("counterclockwise", 1),
("value_a", width),
("delta_a", signed(width + 1)),
("value_b", width),
("delta_b", signed(width + 1)),
])

def elaborate(self, platform):
m = Module()

m.d.comb += [
self.dir_a.ready.eq(self.direction.ready & self.dir_b.valid),
self.dir_b.ready.eq(self.direction.ready & self.dir_a.valid),
]

with m.If(self.direction.ready | ~self.direction.valid):
m.d.sync += [
self.direction.valid.eq(self.dir_a.valid & self.dir_b.valid),
self.direction.value_a.eq(self.dir_a.value),
self.direction.value_b.eq(self.dir_b.value),
self.direction.delta_a.eq(self.dir_a.delta),
self.direction.delta_b.eq(self.dir_b.delta),
]

a_above_b = Signal()
a_above_mid = Signal()
b_above_mid = Signal()
m.d.comb += [
a_above_b.eq(self.dir_a.value > self.dir_b.value),
a_above_mid.eq(self.dir_a.value > (1 << self._width) // 2),
b_above_mid.eq(self.dir_b.value > (1 << self._width) // 2),
]

with m.If(self.direction.ready | ~self.direction.valid):
with m.If(self.dir_a.down & self.dir_b.down):
with m.If(a_above_b):
m.d.sync += self.direction.clockwise.eq(1)
with m.Else():
m.d.sync += self.direction.counterclockwise.eq(1)
with m.Elif(self.dir_a.up & self.dir_b.up):
with m.If(~a_above_b):
m.d.sync += self.direction.clockwise.eq(1)
with m.Else():
m.d.sync += self.direction.counterclockwise.eq(1)
with m.Elif(self.dir_a.up & self.dir_b.down):
with m.If(a_above_mid | b_above_mid):
m.d.sync += self.direction.clockwise.eq(1)
with m.Else():
m.d.sync += self.direction.counterclockwise.eq(1)
with m.Elif(self.dir_a.down & self.dir_b.up):
with m.If(~a_above_mid | ~b_above_mid):
m.d.sync += self.direction.clockwise.eq(1)
with m.Else():
m.d.sync += self.direction.counterclockwise.eq(1)
with m.Else():
m.d.sync += [
self.direction.clockwise.eq(0),
self.direction.counterclockwise.eq(0),
]

return m


class _ReadoutDeadzoneMuxer(Elaboratable):
def __init__(self, width, deadzone=0.8, id_width=0):
self._width = width
self._deadzone = deadzone

self.direction = stream.Endpoint([
("id", id_width),
("clockwise", 1),
("counterclockwise", 1),
("value_a", width),
("delta_a", signed(width + 1)),
("value_b", width),
("delta_b", signed(width + 1)),
])

self.position = stream.Endpoint([
("id", id_width),
("diff", signed(width + 1)),
("value_a", width),
("value_b", width),
])

def elaborate(self, platform):
m = Module()

deadzone_max = int((1 << self._width) * self._deadzone)
deadzone_min = int((1 << self._width) * (1 - self._deadzone))

value = Signal(signed(self._width + 1))
with m.If((self.direction.value_a < deadzone_max) & (self.direction.value_a > deadzone_min)):
with m.If(self.direction.clockwise):
m.d.comb += value.eq(abs(self.direction.delta_a))
with m.Elif(self.direction.counterclockwise):
m.d.comb += value.eq(-abs(self.direction.delta_a))
with m.Else():
m.d.comb += value.eq(0)
with m.Else():
with m.If(self.direction.clockwise):
m.d.comb += value.eq(abs(self.direction.delta_b))
with m.Elif(self.direction.counterclockwise):
m.d.comb += value.eq(-abs(self.direction.delta_b))
with m.Else():
m.d.comb += value.eq(0)

with m.If(self.position.ready | ~self.position.valid):
m.d.sync += [
self.position.valid.eq(self.direction.valid),
self.position.value_a.eq(self.direction.value_a),
self.position.value_b.eq(self.direction.value_b),
self.position.diff.eq(value),
self.position.id.eq(self.direction.id),
]
m.d.comb += self.direction.ready.eq(self.position.ready | ~self.position.valid)

return m


class EndlessPotentiometerDecoder(Elaboratable):
def __init__(self, width, threshold, deadzone, id_width=0):
self._width = width
self._threshold = threshold
self._deadzone = deadzone
self._id_width = id_width

self.adc_readout = stream.Endpoint([
("id", id_width),
("value_a", width),
("previous_value_a", width),
("value_b", width),
("previous_value_b", width),
])

self.position = stream.Endpoint([
("id", id_width),
("diff", signed(width + 1)),
("value_a", width),
("value_b", width),
])

def elaborate(self, platform):
m = Module()

m.submodules.thres_det_a = thres_det_a = _ThresholdDetector(self._width, self._threshold, self._id_width)
m.submodules.thres_det_b = thres_det_b = _ThresholdDetector(self._width, self._threshold, self._id_width)
m.submodules.dir_decoding = dir_decoding = _DirectionDecoding(self._width, self._id_width)
m.submodules.deadzone_mux = deadzone_mux = _ReadoutDeadzoneMuxer(self._width, self._deadzone, self._id_width)
m.d.comb += [
self.adc_readout.ready.eq(thres_det_a.readout.ready & thres_det_b.readout.ready),

thres_det_a.readout.valid.eq(self.adc_readout.valid & thres_det_b.readout.ready),
thres_det_a.readout.id.eq(self.adc_readout.id),
thres_det_a.readout.value.eq(self.adc_readout.value_a),
thres_det_a.readout.previous_value.eq(self.adc_readout.previous_value_a),
thres_det_b.readout.valid.eq(self.adc_readout.valid & thres_det_a.readout.ready),
thres_det_b.readout.id.eq(self.adc_readout.id),
thres_det_b.readout.value.eq(self.adc_readout.value_b),
thres_det_b.readout.previous_value.eq(self.adc_readout.previous_value_b),

thres_det_a.detection.connect(dir_decoding.dir_a),
thres_det_b.detection.connect(dir_decoding.dir_b),

dir_decoding.direction.connect(deadzone_mux.direction),
deadzone_mux.position.connect(self.position),
]

return m
Loading