openai[patch]: propagate computer use actions to .tool_calls #30329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
baskaryan
reviewed
Mar 17, 2025
|
|
||
| Currently supported values are ``"concise"`` or ``"detailed"``. | ||
|
|
||
| .. versionadded:: 0.3.9 |
There was a problem hiding this comment.
Suggested change
| .. versionadded:: 0.3.9 | |
| .. versionadded:: 0.3.10 |
baskaryan
reviewed
Mar 17, 2025
| """Truncation strategy (Responses API). Can be ``"auto"`` or ``"disabled"`` | ||
| (default). If ``"auto"``, model may drop input items from the middle of the | ||
| message sequence to fit the context window. | ||
|
|
||
| .. versionadded:: 0.3.9 |
There was a problem hiding this comment.
Suggested change
| .. versionadded:: 0.3.9 | |
| .. versionadded:: 0.3.10 |
baskaryan
reviewed
Mar 17, 2025
| @@ -2877,8 +2895,13 @@ def _construct_responses_api_payload( | |||
| for legacy_token_param in ["max_tokens", "max_completion_tokens"]: | |||
| if legacy_token_param in payload: | |||
| payload["max_output_tokens"] = payload.pop(legacy_token_param) | |||
| if "reasoning_effort" in payload: | |||
| payload["reasoning"] = {"effort": payload.pop("reasoning_effort")} | |||
| if "reasoning_effort" in payload or "reasoning_summary" in payload: | |||
There was a problem hiding this comment.
wonder if it'd be less confusing to have a single reasoning param that matches openais
baskaryan
reviewed
Mar 17, 2025
| @@ -3127,6 +3150,17 @@ def _construct_lc_result_from_responses_api( | |||
| if _FUNCTION_CALL_IDS_MAP_KEY not in additional_kwargs: | |||
| additional_kwargs[_FUNCTION_CALL_IDS_MAP_KEY] = {} | |||
| additional_kwargs[_FUNCTION_CALL_IDS_MAP_KEY][output.call_id] = output.id | |||
| elif output.type == "computer_call": | |||
| tool_call = { | |||
There was a problem hiding this comment.
do we need to drop these tool calls when sending back messages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.