Skip to content

Hotfix/orm 3 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2024
Merged

Hotfix/orm 3 #136

merged 2 commits into from
Oct 23, 2024

Conversation

TomHAnderson
Copy link
Contributor

No description provided.

@TomHAnderson TomHAnderson requested a review from eigan October 23, 2024 02:06
eigan
eigan approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@eigan eigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should perhaps allow dbal 4, or that might require some more changes in this repo?

@TomHAnderson
Copy link
Contributor Author

Yes, this repo needs to walk forward one step at a time. DBAL 4 would be another step. But for this PR, an upgrade to laravel-doctrine/orm, it should work.

@TomHAnderson TomHAnderson merged commit 6edf93a into laravel-doctrine:3.x Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eigan eigan eigan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomHAnderson @eigan