Skip to content

Conversation

castrohenworx
Copy link
Contributor

Just a small change that does same people some time that want to translate the placeholder for the password in the delete-user-form.blade.php

@driesvints
Copy link
Member

Please rebase with 1.x which fixes the tests. Thanks.

@driesvints driesvints marked this pull request as draft February 9, 2023 12:09
@driesvints driesvints changed the title Add translation to placeholder in delete-user-form.blade.php [1.x] Add translation to placeholder in delete-user-form.blade.php Feb 9, 2023
@castrohenworx
Copy link
Contributor Author

castrohenworx commented Feb 9, 2023 via email

@castrohenworx castrohenworx force-pushed the Translate-Placeholder-In-Delete-User-Form branch from 2127ba3 to cab0de9 Compare February 9, 2023 12:13
@castrohenworx castrohenworx marked this pull request as ready for review February 9, 2023 12:16
@driesvints
Copy link
Member

Sorry, seems tests are still failing. Trying to get them fixed in #251

@castrohenworx
Copy link
Contributor Author

Sorry, seems tests are still failing. Trying to get them fixed in #251

Don't worry. If you take a look, I just changed a single line if code. You can make the change also in one of your current branches and just close this PR if it is easier for you :-)

@taylorotwell taylorotwell merged commit 4043eff into laravel:1.x Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants