[1.x] Pest detection #300
Merged
[1.x] Pest detection #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
commented
Aug 8, 2023
|
Ultimately I think it would be nice to never prompt for the testing framework outside of the Laravel installer, and just autodetect the appropriate testing framework in the installers and Artisan |
driesvints
approved these changes
Aug 8, 2023
nunomaduro
approved these changes
Aug 8, 2023
|
@nunomaduro Couldn't that class exist just because of another dependency? I figured the safest way was to check whether the user had any Pest-specific files in their own project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the standalone Breeze installer to default to Pest when it is already installed, either via the Laravel installer or installed manually.
When running
php artisan breeze:installwith no arguments, the testing framework prompt will still be displayed, but defaulting to Pest when installed:When passing arguments to the installer (e.g.
php artisan breeze:install blade) the prompt does not appear. Currently, it will install PHPUnit tests unless the--pestflag was passed. With this change, it will automatically install Pest tests when appropriate.