[Bug] Schema builder - renameColumn fails on table with enum columns

[itsgoingd]

Example code:

Schema::create('presentations', function($table)
{
...
    $table->enum('repeat_unit', array('DAY', 'WEEK', 'MONTH', 'YEAR'))->default('DAY');
...
});

Schema::table('presentations', function($table)
{
    $table->renameColumn('created', 'created_at');
});

Result:

[Doctrine\DBAL\DBALException]
Unknown database type enum requested, Doctrine\DBAL\Platforms\MySqlPlatform may not support it.

[taylorotwell]

This would be a Doctrine DBAL issue. We may just need to document that this is the case until (and if) they implement something upstream.

[taylorotwell]

Updated documentation.

[shnhrrsn]

The docs aren't correct, they say renaming enum columns isn't support, but this actually happens when renaming any column on a table that contains an enum column.

It looks like the "workaround" for this is to just tell Doctrine an enum is a string: http://wildlyinaccurate.com/doctrine-2-resolving-unknown-database-type-enum-requested

I've attempted to do this in Laravel by doing the following, but the issue still occurs:

$platform = Schema::getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
$platform->registerDoctrineTypeMapping('enum', 'string');

I'm not entirely sure how Laravel interacts with Doctrine so I might grabbing the wrong platform instance (or adding it too late?). Any insight on how to make this work inside of Laravel?

[danharper]

Has anyone had any luck with a workaround on this? Causing some major headaches.

[iflow]

Workaround, during development (if there exists no important data): Drop the column and add a new one.

public function up()
{
    Schema::table('users', function(Blueprint $table)
    {
        $table->dropColumn('name');
    });

    Schema::table('users', function(Blueprint $table)
    {
        $table->text('username');
    });
}

[alexw23]

Any resolution to this issue?

[ejunker]

+1 just ran into this issue. I know it is a Doctrine DBAL issue but I wonder if there is something Laravel can do to provide a workaround.

[alexw23]

I think doctrine is gone in 4.1 :-)

On 22 Nov 2013, at 2:01 am, Eric Junker notifications@github.com wrote:

+1 just ran into this issue. I know it is a Doctrine DBAL issue but I wonder if there is something Laravel can do to provide a workaround.

—
Reply to this email directly or view it on GitHub.

[patrickheeney]

Couldn't laravel leave in this functionality but throw an exception if Doctrine is not loaded? I personally do not need it so I would prefer to not to include doctrine for this one feature. Another suggestion is why not just extend schema to add column renaming which uses doctrine if you need it? It seems like some others would be interested and could help maintain the package?

[alexw23]

I have a feeling it's been replaced using DB commands in 4.1

On 22 Nov 2013, at 6:27 am, Patrick Heeney notifications@github.com wrote:

Couldn't laravel leave in this functionality but throw an exception if Doctrine is not loaded? I personally do not need it so I would prefer to not to include doctrine for this one feature. Another suggestion is why not just extend schema to add column renaming which uses doctrine if you need it? It seems like some others would be interested and could help maintain the package?

—
Reply to this email directly or view it on GitHub.

[alexw23]

Yeah it's still in 4.1

https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Schema/Blueprint.php

On 22 Nov 2013, at 6:27 am, Patrick Heeney notifications@github.com wrote:

Couldn't laravel leave in this functionality but throw an exception if Doctrine is not loaded? I personally do not need it so I would prefer to not to include doctrine for this one feature. Another suggestion is why not just extend schema to add column renaming which uses doctrine if you need it? It seems like some others would be interested and could help maintain the package?

—
Reply to this email directly or view it on GitHub.

[crynobone]

@patrickheeney

Couldn't laravel leave in this functionality but throw an exception if Doctrine is not loaded?

It has been moved to suggest https://github.com/laravel/framework/blob/master/composer.json#L90. If anyone need it, you just update your app composer.json to include it and it would be available.

[patrickheeney]

@crynobone I thought I saw something like that. Thanks for the information.

[reedmaniac]

Ran into this today. It seems that every call of Scheme doing a renameColumn will create an entirely new DoctrineConnection(). That means we cannot simply do a registerDoctrineTypeMapping() globally for enum. So, your options are to either add 'enum' => 'string' directly to Doctrine\DBAL\Platforms\MySqlPlatform's initializeDoctrineTypeMappings() or modify Illuminate\Database\Connection's getDoctrineSchemaManager() to look like this:

public function getDoctrineSchemaManager()
{
    $schema = $this->getDoctrineDriver()->getSchemaManager($this->getDoctrineConnection());
    $schema->getDatabasePlatform()->registerDoctrineTypeMapping('enum', 'string');
    return $schema;
}

It seems extremely unlikely that Doctrine is going to change, so I can only hope that @taylorotwell might think about adding this change in to Laravel. The database I am using is legacy, but I think I am going to try and move it away from enum.