Skip to content

[10.x] Add a new method #47960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mgralikowski
Copy link

@mgralikowski mgralikowski commented Aug 4, 2023

As my PR has been marked as a breaking change, I would suggest introducing a new method that gives us the same result as getDates() from Laravel 9.

This method would be helpful to determine "what model's attributes are date-castable", including timestamps (created_at, updated_at, deleted_at) and defined by a programmer in $casts.

If this PR is accepted, then I would send a PR to the laravelcollective library (and forks)

I sent PR to the upgrade guide as well -> laravel/docs#8940

@GrahamCampbell GrahamCampbell changed the title Add a new method [10.x] Add a new method Aug 4, 2023
@taylorotwell
Copy link
Member

You can just call getCasts() from whatever library you want and look at this information yourself.

mgralikowski added a commit to protrainup/laravel-collective-html that referenced this pull request Aug 10, 2023
Fix "Call to a member function format() on string" after upgrading to Laravel 10.x 

Context: laravel/framework#47960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants