Skip to content

[12.x] Add Enum support for assertJsonPath in AssertableJsonString.php #55516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

[12.x] Add Enum support for assertJsonPath in AssertableJsonString.php #55516

merged 4 commits into from
Apr 23, 2025

Conversation

azim-kordpour
Copy link
Contributor

Hi,
To improve code readability and prevent typos, I added Enum support for assertJsonPath in this PR.

// Before
$this->postJson('book')
     ->assertJsonPath('data.status', BookingStatus::Booked->value);
// After
$this->postJson('book')
     ->assertJsonPath('data.status', BookingStatus::Booked);

shaedrich
shaedrich reviewed Apr 23, 2025
View reviewed changes
@azim-kordpour
Copy link
Contributor Author

@shaedrich
Thank you for the suggestion.

@shaedrich
Copy link
Contributor

@azim-kordpour You're welcome.

@taylorotwell taylorotwell merged commit 573684f into laravel:12.x Apr 23, 2025
58 checks passed
@AhmedAlaa4611 AhmedAlaa4611 mentioned this pull request May 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shaedrich shaedrich shaedrich left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azim-kordpour @shaedrich @taylorotwell