No Auth commands not new skeleton repos #434
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would probably be OK with that if someone wants to work on a PR to make it happen. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don’t think this is the best approach. We’ve introduced three additional repositories, and we’ll have to maintain them every time we update the main
laravel/laravelskeleton. Since we already have thephp artisan install:apicommand, it would make sense to also have commands likephp artisan install:react,php artisan install:vue, andphp artisan install:livewire. These commands should update only the necessary files, rather than requiring the creation and maintenance of three separate repositories.