-
Notifications
You must be signed in to change notification settings - Fork 416
Add the awesome laravel key generate command #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 I was just about to do the same thing. |
You must use spaces for indentation. |
Also, I'm 👎 on adding anything more to Lumen. It's supposed to be really light and basic. |
GrahamCampbell i can't understand your problem. It's only a simple helper for generating the Key. I think all people love this. no key you have to come up with and has therefore not always temptation to use the same. |
@abstractFlo My point is that if people want this, they should probably be using Laravel, not Lumen. |
What? Thats not the point. It's a simple command. Not more, Lumen is awesome and only for this fu... Command i must use laravel? Not really |
@abstractFlo It's not just this command. We have to draw a line somewhere, or everything from Laravel will end up in Lumen because it's "cool". |
that's the point is not, it's still just a matter of simple, quickly and safely to generate a key app. no more and no less but if you mean that everyone who wants to use this command lumen, not to use, then it is so. I can not understand |
My issue is with us registering a command that is only useful once. |
yes, and thats the point. Only useful once, for secure session, cookies, crypt..... |
What if this was a package? |
It might be cool to get this integrated into the lumen installer perhapse? |
@jbrooksuk thats not my opinion. it's a small command. i think this is a base feature of a secure application. Helps people to get secure keys.... |
@GrahamCampbell I like that idea. @abstractFlo the problem with adding another command (just like #23) is that the IOC has to register another class, it adds overhead. |
It's your choice, i think there is no more overhead with this command. |
But of course there is overhead. It's more to be loaded in. Whilst they may be light classes, if you keep adding them, then it's not light anymore :) |
Maybe on |
Please add this PR for enable the awesome command for generating app keys.
I have changed a little bit from the laravel version. No need for app.php in config folder. Overwrite APP_KEY in .env file easy