Skip to content

Add the awesome laravel key generate command #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add the awesome laravel key generate command #11

wants to merge 4 commits into from

Conversation

abstractFlo
Copy link

Please add this PR for enable the awesome command for generating app keys.

I have changed a little bit from the laravel version. No need for app.php in config folder. Overwrite APP_KEY in .env file easy

@jbrooksuk
Copy link
Member

👍 I was just about to do the same thing.

@GrahamCampbell
Copy link
Member

You must use spaces for indentation.

@GrahamCampbell
Copy link
Member

Also, I'm 👎 on adding anything more to Lumen. It's supposed to be really light and basic.

@abstractFlo
Copy link
Author

GrahamCampbell i can't understand your problem. It's only a simple helper for generating the Key. I think all people love this.

no key you have to come up with and has therefore not always temptation to use the same.

@GrahamCampbell
Copy link
Member

@abstractFlo My point is that if people want this, they should probably be using Laravel, not Lumen.

@abstractFlo
Copy link
Author

What? Thats not the point. It's a simple command. Not more, Lumen is awesome and only for this fu... Command i must use laravel? Not really

@GrahamCampbell
Copy link
Member

@abstractFlo It's not just this command. We have to draw a line somewhere, or everything from Laravel will end up in Lumen because it's "cool".

@abstractFlo
Copy link
Author

that's the point is not, it's still just a matter of simple, quickly and safely to generate a key app. no more and no less

but if you mean that everyone who wants to use this command lumen, not to use, then it is so.

I can not understand

@GrahamCampbell
Copy link
Member

My issue is with us registering a command that is only useful once.

@abstractFlo
Copy link
Author

yes, and thats the point. Only useful once, for secure session, cookies, crypt.....

@jbrooksuk
Copy link
Member

What if this was a package?

@GrahamCampbell
Copy link
Member

It might be cool to get this integrated into the lumen installer perhapse?

@abstractFlo
Copy link
Author

@jbrooksuk thats not my opinion. it's a small command. i think this is a base feature of a secure application. Helps people to get secure keys....

@jbrooksuk
Copy link
Member

@GrahamCampbell I like that idea.

@abstractFlo the problem with adding another command (just like #23) is that the IOC has to register another class, it adds overhead.

@abstractFlo
Copy link
Author

It's your choice, i think there is no more overhead with this command.

@jbrooksuk
Copy link
Member

But of course there is overhead. It's more to be loaded in. Whilst they may be light classes, if you keep adding them, then it's not light anymore :)

@tommymarshall
Copy link

Maybe on post-install grab the contents of a randomly generated key from a service/app that is also running Lumen? (key.lumen.laravel.com) How meta would that be ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants