Skip to content

PSR-2 in tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

PSR-2 in tests #9

wants to merge 5 commits into from

Conversation

iwankgb
Copy link
Contributor

@iwankgb iwankgb commented Apr 14, 2015

Following changes have been applied:

  • each class lives in its own file (PSR-1);
  • each class has a namespace defined (PSR-1);
  • lines longer then 120 lines have been broken into multiple lines (PSR-2);
  • ExampleTest class is renamed to FullApplicationTest (PSR-4 - yes, I know it is not part of PSR-2 but it's close enough to me).

Tests had to be modified a bit and TestController file moved to another location to accommodate changes listed above.

Some additional issues have been identiefied:

  • Laravel\Lumen\Application::handle() method is beind used in tests while in real world Laravel\Lumen\Application::run() will be used;

@taylorotwell
Copy link
Member

See comment on previous PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants