Skip to content

Conversation

sapphi-red
Copy link
Contributor

Since rollup is not declared as a dependency or a peerDependency, this import fails in some cases (see https://rushjs.io/pages/advanced/phantom_deps/ for more details).

That was causing the ecosystem-ci to fail.
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/14437826501/job/40481878417#step:8:697

This PR fixes that by using the re-exported types from Vite.

Copy link
Member

@timacdonald timacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate it, @sapphi-red

@sapphi-red
Copy link
Contributor Author

@timacdonald Hi 👋
Would it be possible to get this PR merged? Right now, the ecosystem CI is failing because of this type error, which makes it hard to catch other potential issues.

@taylorotwell taylorotwell merged commit aa697cd into laravel:1.x May 30, 2025
4 checks passed
@sapphi-red sapphi-red deleted the chore/use-rollup-types-from-vite branch May 31, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants