Skip to content

add support for filepaths in compare #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gdementen opened this issue Jul 4, 2022 · 1 comment
Closed

add support for filepaths in compare #229

gdementen opened this issue Jul 4, 2022 · 1 comment
Assignees
@gdementen
Labels
difficulty: low enhancement
Milestone
0.34

Comments

@gdementen
Copy link
Collaborator

I relatively often try to use compare with filenames (containing sessions) but it does not work.

I have to write:

compare(Session(path1), Session(path2), names=[path1.stem, path2.stem])

and I wonder if it would be worth it to implement support for str and Path objects. Honestly, this would probably not be worth it if we had #228, but this is so much easier to implement that it might be worth it as a stopgap solution.
@gdementen gdementen transferred this issue from larray-project/larray Jul 4, 2022
@gdementen
Copy link
Collaborator Author

Given that view() and edit() support filepaths, I see no reason not to implement this in compare().

@gdementen gdementen changed the title add support for filepaths in compare? add support for filepaths in compare Sep 23, 2022
@gdementen gdementen added this to the 0.34 milestone Sep 26, 2022
@gdementen gdementen self-assigned this Sep 28, 2022
gdementen added a commit to gdementen/larray-editor that referenced this issue Oct 14, 2022
@gdementen
FEAT: add support for filepaths (str or Path) in compare (closes larr…
6e0baca 
…ay-project#229)

also changed internal API to use only dict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdementen gdementen

Labels
difficulty: low enhancement
Projects
None yet
Milestone
0.34
Development

No branches or pull requests
1 participant
@gdementen