add staking v2 precompile #64

open-junius · 2025-08-19T14:06:26Z

No description provided.

MichaelTrestman · 2025-08-19T23:31:44Z

docs/evm-tutorials/staking-precompile.md

@@ -114,3 +80,16 @@ In this tutorial, you will interact directly with the staking precompile by usin
   3. Toggle **include option** OFF for the second parameter.
   4. Click the **+** button and find the new stake record.

+## Questions about Call the staking precompile from another smart contract.


Suggested change

## Questions about Call the staking precompile from another smart contract.

## Notes: Calling the staking precompile from another smart contract

MichaelTrestman · 2025-08-19T23:32:04Z

docs/evm-tutorials/staking-precompile.md

@@ -114,3 +80,16 @@ In this tutorial, you will interact directly with the staking precompile by usin
   3. Toggle **include option** OFF for the second parameter.
   4. Click the **+** button and find the new stake record.

+## Questions about Call the staking precompile from another smart contract.
+
+1. which one is the coldkey?


Suggested change

1. which one is the coldkey?

MichaelTrestman · 2025-08-19T23:33:11Z

docs/evm-tutorials/staking-precompile.md

+## Questions about Call the staking precompile from another smart contract.
+
+1. which one is the coldkey?
+   Since the precompile can't get the orginal caller, the precompile takes the contract's address as coldkey.


Suggested change

Since the precompile can't get the orginal caller, the precompile takes the contract's address as coldkey.

- The precompile takes the contract's address as the **coldkey**, since the precompile can't get the original caller.

MichaelTrestman · 2025-08-19T23:33:51Z

docs/evm-tutorials/staking-precompile.md

+
+1. which one is the coldkey?
+   Since the precompile can't get the orginal caller, the precompile takes the contract's address as coldkey.
+2. is the token subtracted from contract or original caller if calling the addStake


Suggested change

2. is the token subtracted from contract or original caller if calling the addStake

MichaelTrestman · 2025-08-19T23:35:48Z

docs/evm-tutorials/staking-precompile.md

+1. which one is the coldkey?
+   Since the precompile can't get the orginal caller, the precompile takes the contract's address as coldkey.
+2. is the token subtracted from contract or original caller if calling the addStake
+   The contract need to pay the token. so must guarantee the balance of contract is enough to call addStake.


Suggested change

The contract need to pay the token. so must guarantee the balance of contract is enough to call addStake.

- The **contract** (not the caller's coldkey) must have sufficient liquidity or the transaction will fail.

MichaelTrestman · 2025-08-19T23:36:09Z

docs/evm-tutorials/staking-precompile.md

+   Since the precompile can't get the orginal caller, the precompile takes the contract's address as coldkey.
+2. is the token subtracted from contract or original caller if calling the addStake
+   The contract need to pay the token. so must guarantee the balance of contract is enough to call addStake.
+3. any security issue for the contract


Suggested change

3. any security issue for the contract

MichaelTrestman · 2025-08-19T23:37:54Z

docs/evm-tutorials/staking-precompile.md

+2. is the token subtracted from contract or original caller if calling the addStake
+   The contract need to pay the token. so must guarantee the balance of contract is enough to call addStake.
+3. any security issue for the contract
+   Because the token for addStake is subtracted from contract. We must set the transaction as priviledged one.


Suggested change

Because the token for addStake is subtracted from contract. We must set the transaction as priviledged one.

- The transaction must be *privileged* because the liquidity for `addStake` is subtracted from contract.

MichaelTrestman · 2025-08-19T23:38:55Z

docs/evm-tutorials/staking-precompile.md

+   The contract need to pay the token. so must guarantee the balance of contract is enough to call addStake.
+3. any security issue for the contract
+   Because the token for addStake is subtracted from contract. We must set the transaction as priviledged one.
+   like the example in [the link will be available after a PR merged in subtensor side]


Suggested change

like the example in [the link will be available after a PR merged in subtensor side]

MichaelTrestman · 2025-08-19T23:39:10Z

docs/evm-tutorials/staking-precompile.md

+3. any security issue for the contract
+   Because the token for addStake is subtracted from contract. We must set the transaction as priviledged one.
+   like the example in [the link will be available after a PR merged in subtensor side]
+4. the unit of amount in addStake, removeStake


Suggested change

4. the unit of amount in addStake, removeStake

MichaelTrestman · 2025-08-19T23:40:31Z

docs/evm-tutorials/staking-precompile.md

+   Because the token for addStake is subtracted from contract. We must set the transaction as priviledged one.
+   like the example in [the link will be available after a PR merged in subtensor side]
+4. the unit of amount in addStake, removeStake
+   As the function parameter indicates, all these are aligned with the decimal of TAO


Suggested change

As the function parameter indicates, all these are aligned with the decimal of TAO

- As the function parameter indicates, `amount` in `addStake` and `removeStake` are specified in TAO $\tau$.

MichaelTrestman · 2025-08-19T23:41:39Z

docs/evm-tutorials/staking-precompile.md

+   like the example in [the link will be available after a PR merged in subtensor side]
+4. the unit of amount in addStake, removeStake
+   As the function parameter indicates, all these are aligned with the decimal of TAO
+5. If transfer token to contract in msg.value, and trigger the contract to call precompile. should the function in contract do the decimal convert.


Suggested change

5. If transfer token to contract in msg.value, and trigger the contract to call precompile. should the function in contract do the decimal convert.

MichaelTrestman · 2025-08-19T23:52:26Z

docs/evm-tutorials/staking-precompile.md

+4. the unit of amount in addStake, removeStake
+   As the function parameter indicates, all these are aligned with the decimal of TAO
+5. If transfer token to contract in msg.value, and trigger the contract to call precompile. should the function in contract do the decimal convert.
+   Yes. the decimal in msg.value is 18. need conversion like `uint256 amount = msg.value / 1e9`


Suggested change

Yes. the decimal in msg.value is 18. need conversion like `uint256 amount = msg.value / 1e9`

- Note that when transferring liquidity to the contract, `msg.value` is in denominations of 1/1e18 TAO $\tau$ . The staking precompile, however, expects RAO, 1/1e9 TAO $\tau$. You must convert before calling it: **uint256 amount = msg.value / 1e9**.

MichaelTrestman · 2025-08-19T23:54:01Z

docs/evm-tutorials/staking-precompile.md

@@ -40,13 +39,17 @@ btcli subnet register --network ws://127.0.0.1:9944
   - Click on **Submit Transaction** at the bottom right. This will open the **authorize transaction** window.
   - On this **authorize transaction** window, make sure the **sign and submit** toggle is ON and click on the **Sign and Submit** on the bottom right.

+## Staking V1 and V2.
+
+There are two versions of staking precompile implemenation, V1 and V2. The contract address for V1 is `0x0000000000000000000000000000000000000801`. The address for V2 is `0x0000000000000000000000000000000000000805`. The V1 is deprecated, just being kept for compatiable with old interface. The major difference between V1 and V2 is, the staking amount is fetched from the msg.value in V1. Then precompile transfer the token back to caller. It is misleading and confuses the solidity developers. In V2 implementation, all amount parameters are defined as parameter of transaction.


Suggested change

There are two versions of staking precompile implemenation, V1 and V2. The contract address for V1 is `0x0000000000000000000000000000000000000801`. The address for V2 is `0x0000000000000000000000000000000000000805`. The V1 is deprecated, just being kept for compatiable with old interface. The major difference between V1 and V2 is, the staking amount is fetched from the msg.value in V1. Then precompile transfer the token back to caller. It is misleading and confuses the solidity developers. In V2 implementation, all amount parameters are defined as parameter of transaction.

There are two versions of staking precompile implemenation, V1 and V2. The contract address for V1 is `0x0000000000000000000000000000000000000801`. The address for V2 is `0x0000000000000000000000000000000000000805`. V1 is deprecated, but is kept for backwards-compatibility. The major difference between V1 and V2 is that the staking amount is fetched from the `msg.value` in V1. Then precompile transfers the token back to the caller. It is misleading and confuses solidity developers. In the V2 implementation, all amount parameters are defined as parameter of transaction.

MichaelTrestman · 2025-08-19T23:54:41Z

docs/evm-tutorials/staking-precompile.md

 ## Call the staking precompile from another smart contract (staking pool use case)

-In this interaction you will compile [`stake.sol`](https://github.com/opentensor/evm-bittensor/blob/main/solidity/stake.sol), a smart contract Solidity code and execute it on the subtensor EVM. This `stake.sol` will, in turn, call the staking precompile that is already deployed in the subtensor EVM.
+In this interaction you will compile [`stakeV2.sol`](https://github.com/opentensor/evm-bittensor/blob/main/solidity/stakeV2.sol), a smart contract Solidity code and execute it on the subtensor EVM. This `stakeV2.sol` will, in turn, call the staking precompile that is already deployed in the subtensor EVM.


Suggested change

In this interaction you will compile [`stakeV2.sol`](https://github.com/opentensor/evm-bittensor/blob/main/solidity/stakeV2.sol), a smart contract Solidity code and execute it on the subtensor EVM. This `stakeV2.sol` will, in turn, call the staking precompile that is already deployed in the subtensor EVM.

In this interaction you will compile [`stakeV2.sol`](https://github.com/opentensor/evm-bittensor/blob/main/solidity/stakeV2.sol), a Solidity smart contract code, and execute it on the Subtensor EVM. This `stakeV2.sol` will, in turn, call the staking precompile that is already deployed on the Subtensor EVM.

MichaelTrestman · 2025-08-19T23:55:06Z

docs/evm-tutorials/staking-precompile.md

-   ```
-
-2. Copy staking precompile address `0x0000000000000000000000000000000000000801` to the **At Address** field in Remix IDE, and click **At Address** button.
+1. Copy this below ABI from https://github.com/opentensor/subtensor/blob/main/precompiles/src/solidity/stakingV2.abi into Remix IDE as a new file.


Suggested change

1. Copy this below ABI from https://github.com/opentensor/subtensor/blob/main/precompiles/src/solidity/stakingV2.abi into Remix IDE as a new file.

1. Copy the ABI from https://github.com/opentensor/subtensor/blob/main/precompiles/src/solidity/stakingV2.abi into Remix IDE as a new file.

MichaelTrestman

Great, thanks for the changes!
I just made some copy cleanup suggestions, but if these look ok, go ahead and merge, thanks!

This reverts commit 0d6d239.

add staking v2 precompile

52ad1ce

open-junius self-assigned this Aug 19, 2025

open-junius requested a review from MichaelTrestman August 19, 2025 14:06

MichaelTrestman reviewed Aug 19, 2025

View reviewed changes

MichaelTrestman approved these changes Aug 19, 2025

View reviewed changes

MichaelTrestman merged commit 0d6d239 into latent-to:main Aug 19, 2025

MichaelTrestman added a commit that referenced this pull request Aug 19, 2025

Revert "add staking v2 precompile (#64)"

35f8376

This reverts commit 0d6d239.

MichaelTrestman mentioned this pull request Aug 19, 2025

Revert "add staking v2 precompile" #66

Closed

MichaelTrestman added a commit that referenced this pull request Aug 20, 2025

finishing polish on #64

4ac6f46

	## Questions about Call the staking precompile from another smart contract.
	## Notes: Calling the staking precompile from another smart contract

	Since the precompile can't get the orginal caller, the precompile takes the contract's address as coldkey.
	- The precompile takes the contract's address as the coldkey, since the precompile can't get the original caller.

	The contract need to pay the token. so must guarantee the balance of contract is enough to call addStake.
	- The contract (not the caller's coldkey) must have sufficient liquidity or the transaction will fail.

	Because the token for addStake is subtracted from contract. We must set the transaction as priviledged one.
	- The transaction must be privileged because the liquidity for `addStake` is subtracted from contract.

	like the example in [the link will be available after a PR merged in subtensor side]
	<!-- example in link will be available after a PR merged in subtensor side -->

	As the function parameter indicates, all these are aligned with the decimal of TAO
	- As the function parameter indicates, `amount` in `addStake` and `removeStake` are specified in TAO $\tau$.

	Yes. the decimal in msg.value is 18. need conversion like `uint256 amount = msg.value / 1e9`
	- Note that when transferring liquidity to the contract, `msg.value` is in denominations of 1/1e18 TAO $\tau$ . The staking precompile, however, expects RAO, 1/1e9 TAO $\tau$. You must convert before calling it: uint256 amount = msg.value / 1e9.

	In this interaction you will compile [`stakeV2.sol`](https://github.com/opentensor/evm-bittensor/blob/main/solidity/stakeV2.sol), a smart contract Solidity code and execute it on the subtensor EVM. This `stakeV2.sol` will, in turn, call the staking precompile that is already deployed in the subtensor EVM.
	In this interaction you will compile [`stakeV2.sol`](https://github.com/opentensor/evm-bittensor/blob/main/solidity/stakeV2.sol), a Solidity smart contract code, and execute it on the Subtensor EVM. This `stakeV2.sol` will, in turn, call the staking precompile that is already deployed on the Subtensor EVM.

	1. Copy this below ABI from https://github.com/opentensor/subtensor/blob/main/precompiles/src/solidity/stakingV2.abi into Remix IDE as a new file.
	1. Copy the ABI from https://github.com/opentensor/subtensor/blob/main/precompiles/src/solidity/stakingV2.abi into Remix IDE as a new file.

add staking v2 precompile #64

add staking v2 precompile #64

Uh oh!

Conversation

open-junius commented Aug 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichaelTrestman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!