feat(store): use custom error for deleteCount overflow #3611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
_spliceDynamicData
with an overflowingdeleteCount
, it triggers a default arithmetic errorIf it instead triggered
Store_InvalidSplice
, it would've saved me a couple hours of debuggingI also add tests, for this new behaviour and for the previous way
Store_InvalidSplice
was usedMy used of
unchecked
isn't important and I can remove it if you don't like itI assume this is also blocked by audit, so I'm stockpiling PRs for whenever that happens
note to self about updating store logs:
pnpm with-anvil vitest --update --hookTimeout=1000000