Skip to content

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Feb 28, 2025

Calling _spliceDynamicData with an overflowing deleteCount, it triggers a default arithmetic error

If it instead triggered Store_InvalidSplice, it would've saved me a couple hours of debugging
I also add tests, for this new behaviour and for the previous way Store_InvalidSplice was used

My used of unchecked isn't important and I can remove it if you don't like it

I assume this is also blocked by audit, so I'm stockpiling PRs for whenever that happens

note to self about updating store logs: pnpm with-anvil vitest --update --hookTimeout=1000000

Copy link

changeset-bot bot commented Feb 28, 2025

⚠️ No Changeset found

Latest commit: 5ce5f6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frolic
Copy link
Member

frolic commented Feb 28, 2025

ooc is this similar to #3521 ?

@dk1a
Copy link
Contributor Author

dk1a commented Feb 28, 2025

The arithemetic error I replace with a custom error comes from the definition of previousFieldLength, which is unchanged in #3521
The error alvarius changes is unrelated and happens later

(edited after realizing it's even less related than I initially thought, in case you read the previous version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants