Skip to content

clippy::used_underscore_binding #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whatisaphone opened this issue May 30, 2021 · 2 comments · Fixed by #1264
Closed

clippy::used_underscore_binding #1263

whatisaphone opened this issue May 30, 2021 · 2 comments · Fixed by #1264
Labels
E-easy good first issue Good for newcomers macros

Comments

@whatisaphone
Copy link

whatisaphone commented May 30, 2021 •
edited
Loading

The query! macro can trigger clippy::used_underscore_binding due to this variable which is used a few lines later (clippy doesn't care about the if false {}). It could be fixed by renaming _expr to expr
@abonander
Copy link
Collaborator

I think without the underscore I was getting unused warnings even with the method call, but it's worth a shot. This would be pretty easy to try.

@RhnSharma
Copy link
Contributor

I would like to take this one.

@RhnSharma RhnSharma mentioned this issue May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy good first issue Good for newcomers macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename _expr to expr RhnSharma/sqlx
3 participants
@whatisaphone @abonander @RhnSharma