Skip to content

Use postgres as maintenance db unless maintaining postgres itself #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Use postgres as maintenance db unless maintaining postgres itself #1339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sqlx-core/src/postgres/migrate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ fn parse_for_maintenance(uri: &str) -> Result<(PgConnectOptions, String), Error>
.to_owned();

// switch us to the maintenance database
// use `postgres` _unless_ the current user is postgres, in which case, use `template1`
// use `postgres` _unless_ the database is postgres, in which case, use `template1`
// this matches the behavior of the `createdb` util
options.database = if options.username == "postgres" {
options.database = if database == "postgres" {
Some("template1".into())
} else {
Some("postgres".into())
Expand Down