Skip to content

[SQLite] encoding & decoding NaiveTime with correct format #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2021
Merged

[SQLite] encoding & decoding NaiveTime with correct format #1459

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ed0d24
Fix SQLite encoding format
billy1624 Sep 28, 2021
2e63948
Update SQLite decoding format
billy1624 Sep 28, 2021
9f95cbc
Update sqlx-core/src/sqlite/types/chrono.rs
abonander Oct 1, 2021
3ccbf9c
fixup: add `#[rustfmt::skip]`
abonander Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sqlx-core/src/sqlite/types/chrono.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl Encode<'_, Sqlite> for NaiveDate {

impl Encode<'_, Sqlite> for NaiveTime {
fn encode_by_ref(&self, buf: &mut Vec<SqliteArgumentValue<'_>>) -> IsNull {
Encode::<Sqlite>::encode(self.format("%T%.f%").to_string(), buf)
Encode::<Sqlite>::encode(self.format("%T%.f").to_string(), buf)
}
}

Expand Down Expand Up @@ -179,9 +179,11 @@ impl<'r> Decode<'r, Sqlite> for NaiveTime {

// Loop over common time patterns, inspired by Diesel
// https://github.com/diesel-rs/diesel/blob/93ab183bcb06c69c0aee4a7557b6798fd52dd0d8/diesel/src/sqlite/types/date_and_time/chrono.rs#L29-L47
#[rustfmt::skip] // don't like how rustfmt mangles the comments
let sqlite_time_formats = &[
// Most likely format
"%T.f", // Other formats in order of appearance in docs
"%T.f", "%T%.f",
// Other formats in order of appearance in docs
"%R", "%RZ", "%T%.fZ", "%R%:z", "%T%.f%:z",
];

Expand Down