-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add command for uploading frontend sourcemaps [OB-143] #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Original prompt from [email protected]:
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Aside @Vadman97 I made some suggestions that caused code changes. I think it's good to merge, but you'll need to re-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…m package Co-Authored-By: [email protected] <[email protected]>
…tly in Go Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
Co-Authored-By: [email protected] <[email protected]>
addressing feedback raised in https://github.com/launchdarkly/observability/pull/71 to make the authentication strategy more robust (forwarding the access token to highlight to perform the authentication there. let me know if there are any concerns with this approach. |
d30e64a
to
a891dec
Compare
validated with changes from https://github.com/launchdarkly/observability/pull/71 ![]() |
Add sourcemaps command for uploading frontend sourcemaps
This PR adds a new
sourcemaps
command to the LaunchDarkly CLI for uploading JavaScript sourcemaps to LaunchDarkly for error monitoring. The implementation is based on the existing sourcemap uploader in theobservability-sdk
repository.Implementation Details
sourcemaps
command with anupload
subcommand--api-key
(required): The LaunchDarkly Observability API key--app-version
: The current version of your deploy--path
: Sets the directory of where the sourcemaps are (defaults to current directory)--base-path
: An optional base path for the uploaded sourcemaps--backend-url
: An optional backend url for self-hosted deploymentsFeatures
.js.map
files in the specified directorynode_modules
directories when searching for sourcemapsTesting
Link to Devin run
https://app.devin.ai/sessions/11aee1380731458dacd92573c687372f
Requested by: [email protected]
Related Jira issue: O11Y-5: create a ldcli sourcemap uploader command