Skip to content

Laravel 10.x Compatibility #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift updated your build matrix for Laravel 10. However, since you are supporting older versions of Laravel, you need to add the following exclusions:

exclude:
  - laravel: 10.*
    php: 8.0
  - laravel: 10.*
    php: 7.4
  - laravel: 10.*
    php: 7.3
  - laravel: 10.*
    php: 7.2
  - laravel: 10.*
    php: 7.1

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-nestedset.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "kalnoy/nestedset": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@ifox
Copy link
Contributor

ifox commented Feb 15, 2023

Hi @lazychaser, it would be great to review and merge this. Let me know if I can help. Cheers!

@jonnott
Copy link
Collaborator

jonnott commented Feb 15, 2023

@ifox @lazychaser Seems like this would be better targeted at the v6.x branch of this package, which already supports Laravel 9.x.

@jonnott
Copy link
Collaborator

jonnott commented Feb 15, 2023

@ifox #578

@lazychaser lazychaser closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants