Skip to content

Conversation

eyihluyc
Copy link
Contributor

This PR adds highlights to v4.19 release notes and reorganizes entries in the extended list.

Comment on lines 134 to 140
* [#7366](https://github.com/leanprover/lean4/pull/7366) adds server-side support for dedicated 'unsolved goals' and
'goals accomplished' diagnostics that will have special support in the
Lean 4 VS Code extension. The special 'unsolved goals' diagnostic is
adapted from the 'unsolved goals' error diagnostic, while the 'goals
accomplished' diagnostic is issued when a `theorem` or `Prop`-typed
`example` has no errors or `sorry`s. The Lean 4 VS Code extension
companion PR is at [leanprover/vscode-lean4#585](https://github.com/leanprover/vscode-lean4/pull/585).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this first, as the most user-visible change, and maybe even add a paragraph.

The companion change to the Lean 4 VS Code extension also adds new error and warning gutter decorations…

(See leanprover/vscode-lean4#585 for details). This deserves highlighting :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Addressed in f06e06b

Comment on lines +372 to +373
* [#7084](https://github.com/leanprover/lean4/pull/7084) enables the elaboration of theorem bodies, i.e. proofs, to
happen in parallel to each other as well as to other elaboration tasks.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a big deal, maybe second highlight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added in f06e06b

@nomeata
Copy link
Collaborator

nomeata commented May 21, 2025

@david-christiansen , are you ok with me merging such PRs or would you want to have a second look?

@david-christiansen david-christiansen added the HTML available HTML has been generated for this PR label May 21, 2025
Copy link
Contributor

Preview for this PR is ready! 🎉 (also as a proofreading version). built with commit f06e06b.

@david-christiansen
Copy link
Collaborator

Go for it. If you think something needs special attention, or you're not confident about some aspect, just let me know.

@nomeata nomeata merged commit 19b7bef into leanprover:main May 21, 2025
9 checks passed
Vierkantor pushed a commit that referenced this pull request Jun 4, 2025
This PR adds highlights to v4.19 release notes and reorganizes entries
in the extended list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTML available HTML has been generated for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants