-
Notifications
You must be signed in to change notification settings - Fork 38
chore: add highlights for v4.19 release notes #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Manual/Releases/v4.19.0.lean
Outdated
* [#7366](https://github.com/leanprover/lean4/pull/7366) adds server-side support for dedicated 'unsolved goals' and | ||
'goals accomplished' diagnostics that will have special support in the | ||
Lean 4 VS Code extension. The special 'unsolved goals' diagnostic is | ||
adapted from the 'unsolved goals' error diagnostic, while the 'goals | ||
accomplished' diagnostic is issued when a `theorem` or `Prop`-typed | ||
`example` has no errors or `sorry`s. The Lean 4 VS Code extension | ||
companion PR is at [leanprover/vscode-lean4#585](https://github.com/leanprover/vscode-lean4/pull/585). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move this first, as the most user-visible change, and maybe even add a paragraph.
The companion change to the Lean 4 VS Code extension also adds new error and warning gutter decorations…
(See leanprover/vscode-lean4#585 for details). This deserves highlighting :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Addressed in f06e06b
* [#7084](https://github.com/leanprover/lean4/pull/7084) enables the elaboration of theorem bodies, i.e. proofs, to | ||
happen in parallel to each other as well as to other elaboration tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also a big deal, maybe second highlight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added in f06e06b
@david-christiansen , are you ok with me merging such PRs or would you want to have a second look? |
Preview for this PR is ready! 🎉 (also as a proofreading version). built with commit f06e06b. |
Go for it. If you think something needs special attention, or you're not confident about some aspect, just let me know. |
This PR adds highlights to v4.19 release notes and reorganizes entries in the extended list.
This PR adds highlights to v4.19 release notes and reorganizes entries in the extended list.