-
Notifications
You must be signed in to change notification settings - Fork 38
feat: add error explanation elaboration and manual page #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add error explanation elaboration and manual page #481
Conversation
523c931
to
5f49d7d
Compare
c3c3a07
to
deee512
Compare
5f49d7d
to
eff8b02
Compare
deee512
to
c132464
Compare
c132464
to
237f71f
Compare
I've changed in core the wording of the error explanation that's currently blocking the build, but it unfortunately won't land until the next nightly. |
I think that we should just disable the prose linter for error explanations. The feedback loop is way too long for it to be worth it. If we want one for them, then we should configure it upstream, in the |
I can just make the prose linter ignore any HTML that contains an element with class |
You haven't enabled the "allow maintainers to edit PR" flag, so I can't push it directly, but I do have a fix for this. Can you enable the flag? |
I think you should be able to commit directly to the |
I managed to confuse myself about the role the |
This commit drops error name prefixes from the table and sidebar and allows hyphenation at reasonable split points.
8f37451
to
0f0d2ce
Compare
For consistency with the rest of the manual
Preview for this PR is ready! 🎉 (also as a proofreading version). built with commit d959a6a. |
This PR adds elaboration and a manual page for error explanations. --------- Co-authored-by: David Thrane Christiansen <[email protected]>
This PR adds elaboration and a manual page for error explanations. --------- Co-authored-by: David Thrane Christiansen <[email protected]>
This PR adds elaboration and a manual page for error explanations.